[epiphany/mcatanzaro/scan-build-discoveries: 2/2] shell: initialize ctx at most once in before_emit



commit 6e2a73fe7e132b1c8e5e36430fc0270c715c4d0f
Author: Michael Catanzaro <mcatanzaro gnome org>
Date:   Fri Dec 27 11:04:52 2019 -0600

    shell: initialize ctx at most once in before_emit
    
    There should never be multiple ephy-shell-startup-context keys in this
    dictionary. That's impossible. But, if there were to be, we would leak
    ctx here. Avoid this.

 src/ephy-shell.c | 1 +
 1 file changed, 1 insertion(+)
---
diff --git a/src/ephy-shell.c b/src/ephy-shell.c
index ff0e15a68..0acb0faa5 100644
--- a/src/ephy-shell.c
+++ b/src/ephy-shell.c
@@ -619,6 +619,7 @@ ephy_shell_before_emit (GApplication *application,
             break;
         }
       }
+      break;
     }
   }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]