[epiphany/mcatanzaro/bookmarks-export-error: 4/4] Fix crash in ephy_bookmarks_manager_init()
- From: Michael Catanzaro <mcatanzaro src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [epiphany/mcatanzaro/bookmarks-export-error: 4/4] Fix crash in ephy_bookmarks_manager_init()
- Date: Mon, 16 Dec 2019 21:05:15 +0000 (UTC)
commit 6d83ac8f405c1cd1fbf6ef4b54d1dd98475ae7cc
Author: Michael Catanzaro <mcatanzaro gnome org>
Date: Mon Dec 16 15:00:33 2019 -0600
Fix crash in ephy_bookmarks_manager_init()
This is a regression from 3.34, we have 1341 reports of this in Fedora
from 513 unique users. Problem is the error returned is uninitialized
memory. Oops.
https://bugzilla.redhat.com/show_bug.cgi?id=1768089
src/bookmarks/ephy-bookmarks-manager.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/src/bookmarks/ephy-bookmarks-manager.c b/src/bookmarks/ephy-bookmarks-manager.c
index efddec92f..09513dc8d 100644
--- a/src/bookmarks/ephy-bookmarks-manager.c
+++ b/src/bookmarks/ephy-bookmarks-manager.c
@@ -622,7 +622,7 @@ bookmarks_export_cb (GObject *source_object,
{
EphyBookmarksManager *self = EPHY_BOOKMARKS_MANAGER (source_object);
g_autoptr (GTask) task = user_data;
- GError *error;
+ GError *error = NULL;
if (!ephy_bookmarks_export_finish (self, result, &error)) {
g_task_return_error (task, error);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]