[gtk/wip/otte/listview: 1/150] treeview: Don't create a cyclic reference



commit 2c48c1c9d92db8b595f27a3f3688c479e292f9c8
Author: Benjamin Otte <otte redhat com>
Date:   Sun Dec 8 06:26:26 2019 +0100

    treeview: Don't create a cyclic reference
    
    TreeRowReference refs the proxy object, so don't use proxies.

 gtk/gtktreeview.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
---
diff --git a/gtk/gtktreeview.c b/gtk/gtktreeview.c
index 647d2e1440..4c51ba451e 100644
--- a/gtk/gtktreeview.c
+++ b/gtk/gtktreeview.c
@@ -3760,10 +3760,8 @@ gtk_tree_view_stop_rubber_band (GtkTreeView *tree_view)
           if (tree_view->priv->anchor)
             gtk_tree_row_reference_free (tree_view->priv->anchor);
 
-          tree_view->priv->anchor =
-            gtk_tree_row_reference_new_proxy (G_OBJECT (tree_view),
-                                              tree_view->priv->model,
-                                              tmp_path);
+          tree_view->priv->anchor = gtk_tree_row_reference_new (tree_view->priv->model,
+                                                                tmp_path);
 
           gtk_tree_path_free (tmp_path);
         }
@@ -9341,8 +9339,7 @@ _gtk_tree_view_set_anchor_path (GtkTreeView *tree_view,
 
   if (anchor_path && tree_view->priv->model)
     tree_view->priv->anchor =
-      gtk_tree_row_reference_new_proxy (G_OBJECT (tree_view), 
-                                       tree_view->priv->model, anchor_path);
+      gtk_tree_row_reference_new (tree_view->priv->model, anchor_path);
 }
 
 GtkTreeRBTree *


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]