[citemplates: 1/3] Replace review apps with artifacts:expose_as

[Jordan Petridis <jpetridis src gnome org>]

commit 544836ee58f91a735616ecb04ea857a66d2bb699
Author: Jordan Petridis <jpetridis gnome org>
Date:   Sat Nov 30 20:46:19 2019 +0200

    Replace review apps with artifacts:expose_as
    
    This is a new gitlab feature that fits our usecase of exposing
    the flatpak-bundle into the MRs widget/page, but significantly
    simplet than setting up review apps.
    
    https://docs.gitlab.com/ee/ci/yaml/README.html#artifactsexpose_as
    
    The review app pages are now deprecated, but kept in the template
    (effectively disabled) so they won't break any existing setups.

 flatpak/flatpak-ci-initiative-sdk-extensions.yml | 28 ++++++------------------
 flatpak/flatpak_ci_initiative.yml                | 28 ++++++------------------
 2 files changed, 14 insertions(+), 42 deletions(-)
---
diff --git a/flatpak/flatpak-ci-initiative-sdk-extensions.yml 
b/flatpak/flatpak-ci-initiative-sdk-extensions.yml
index 040fb92..aa1e874 100644
--- a/flatpak/flatpak-ci-initiative-sdk-extensions.yml
+++ b/flatpak/flatpak-ci-initiative-sdk-extensions.yml
@@ -72,13 +72,15 @@
     # Generate a Flatpak bundle
     - flatpak build-bundle repo ${BUNDLE} --runtime-repo=${RUNTIME_REPO} ${APP_ID} ${BRANCH}
   artifacts:
+    name: 'Flatpak artifacts'
+    expose_as: 'Get Flatpak bundle here'
     when: 'always'
     paths:
       - "${BUNDLE}"
       - 'repo/'
       - '_build/meson-logs/meson-log.txt'
       - '_build/meson-logs/testlog.txt'
-    expire_in: 2 days
+    expire_in: 14 days
   cache:
     key: "$CI_JOB_NAME"
     paths:
@@ -88,38 +90,22 @@
 .review:
   stage: 'deploy'
   script:
-    - echo "Generating flatpak deployment"
-  artifacts:
-    paths:
-      - "${BUNDLE}"
-    expire_in: 30 days
-  environment:
-    name: review/$CI_COMMIT_REF_NAME
-    url: https://gitlab.gnome.org/$CI_PROJECT_PATH/-/jobs/$CI_JOB_ID/artifacts/raw/${BUNDLE}
-    on_stop: stop_review
+    - echo "This job has been deprecated and is no longer needed!"
   except:
     refs:
       - 'tags'
-      # No need to run on the upstream master branch either
       - 'master'
-      # don't run on stable branches
-      - /^gnome-\d-\d\d$/
+      - 'branches'
 
 .stop_review:
   stage: 'deploy'
   script:
-    - echo "Stopping flatpak deployment"
-  when: 'manual'
-  environment:
-    name: review/$CI_COMMIT_REF_NAME
-    action: 'stop'
+    - echo "This job has been deprecated and is no longer needed!"
   except:
     refs:
       - 'tags'
-      # No need to run on the upstream master branch either
       - 'master'
-      # don't run on stable branches
-      - /^gnome-\d-\d\d$/
+      - 'branches'
 
 .publish_nightly:
   image: 'registry.gitlab.gnome.org/gnome/gnome-runtime-images/flat-manager-client'
diff --git a/flatpak/flatpak_ci_initiative.yml b/flatpak/flatpak_ci_initiative.yml
index b5f008a..1206e19 100644
--- a/flatpak/flatpak_ci_initiative.yml
+++ b/flatpak/flatpak_ci_initiative.yml
@@ -69,13 +69,15 @@
     # Generate a Flatpak bundle
     - flatpak build-bundle repo ${BUNDLE} --runtime-repo=${RUNTIME_REPO} ${APP_ID} ${BRANCH}
   artifacts:
+    name: 'Flatpak artifacts'
+    expose_as: 'Get Flatpak bundle here'
     when: 'always'
     paths:
       - "${BUNDLE}"
       - 'repo/'
       - '_build/meson-logs/meson-log.txt'
       - '_build/meson-logs/testlog.txt'
-    expire_in: 2 days
+    expire_in: 14 days
   cache:
     key: "$CI_JOB_NAME"
     paths:
@@ -85,38 +87,22 @@
 .review:
   stage: 'deploy'
   script:
-    - echo "Generating flatpak deployment"
-  artifacts:
-    paths:
-      - "${BUNDLE}"
-    expire_in: 30 days
-  environment:
-    name: review/$CI_COMMIT_REF_NAME
-    url: https://gitlab.gnome.org/$CI_PROJECT_PATH/-/jobs/$CI_JOB_ID/artifacts/raw/${BUNDLE}
-    on_stop: stop_review
+    - echo "This job has been deprecated and is no longer needed!"
   except:
     refs:
       - 'tags'
-      # No need to run on the upstream master branch either
       - 'master'
-      # don't run on stable branches
-      - /^gnome-\d-\d\d$/
+      - 'branches'
 
 .stop_review:
   stage: 'deploy'
   script:
-    - echo "Stopping flatpak deployment"
-  when: 'manual'
-  environment:
-    name: review/$CI_COMMIT_REF_NAME
-    action: 'stop'
+    - echo "This job has been deprecated and is no longer needed!"
   except:
     refs:
       - 'tags'
-      # No need to run on the upstream master branch either
       - 'master'
-      # don't run on stable branches
-      - /^gnome-\d-\d\d$/
+      - 'branches'
 
 .publish_nightly:
   image: 'registry.gitlab.gnome.org/gnome/gnome-runtime-images/flat-manager-client'