[libgweather/wip/hadess/fix-invalid-forecast: 3/5] tests: Better weather debugging data



commit 2c670ed9b3f9448baa15789c61b70ec76fda85cf
Author: Bastien Nocera <hadess hadess net>
Date:   Tue Aug 27 15:06:13 2019 +0300

    tests: Better weather debugging data

 libgweather/gweather-weather.c |  3 +++
 libgweather/test_weather.c     | 10 +++++++++-
 2 files changed, 12 insertions(+), 1 deletion(-)
---
diff --git a/libgweather/gweather-weather.c b/libgweather/gweather-weather.c
index 3bb4eaa..7ec0cdb 100644
--- a/libgweather/gweather-weather.c
+++ b/libgweather/gweather-weather.c
@@ -332,6 +332,9 @@ _gweather_info_request_done (GWeatherInfo *info,
 
     if (info->priv->requests_pending == NULL)
         g_signal_emit (info, gweather_info_signals[SIGNAL_UPDATED], 0);
+    else
+        g_debug ("Not emitting 'updated' as there are still %d requests pending",
+                 g_slist_length (info->priv->requests_pending));
 }
 
 /* it's OK to pass in NULL */
diff --git a/libgweather/test_weather.c b/libgweather/test_weather.c
index 68217d4..832dee0 100644
--- a/libgweather/test_weather.c
+++ b/libgweather/test_weather.c
@@ -57,14 +57,22 @@ weather_updated (GWeatherInfo *info,
     static gboolean weather_printed = FALSE;
     static gboolean forecast_printed = FALSE;
 
+    if (!gweather_info_is_valid (info)) {
+        g_warning ("Weather is invalid");
+        return;
+    }
+
     if (gweather_info_get_value_update (info, &val)) {
         g_message ("Weather now: %s", gweather_info_get_temp_summary (info));
         weather_printed = TRUE;
     }
 
     forecasts = gweather_info_get_forecast_list (info);
-    if (!forecasts)
+    if (!forecasts) {
+        if (!weather_printed)
+           g_warning ("No forecasts, but no weather either?!");
         return;
+    }
 
     for (l = forecasts; l != NULL; l = l->next) {
         GWeatherInfo *i = l->data;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]