[at-spi2-atk: 1/2] cache-adaptor: Fix crash when no toolkit name is set
- From: Mike Gorse <mgorse src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [at-spi2-atk: 1/2] cache-adaptor: Fix crash when no toolkit name is set
- Date: Tue, 27 Aug 2019 03:40:20 +0000 (UTC)
commit e84fdbe454d4e2e9b6202ce140e167a00705c64e
Author: Samuel Thibault <samuel thibault ens-lyon org>
Date: Tue Aug 27 01:07:22 2019 +0200
cache-adaptor: Fix crash when no toolkit name is set
atk_get_toolkit_name may return NULL when e.g. running the pyatspi2 test
suite. Callers of get_toolkit_name expect a non-NULL value (passed to
strcmp), so return a default string.
atk-adaptor/adaptors/cache-adaptor.c | 3 +++
1 file changed, 3 insertions(+)
---
diff --git a/atk-adaptor/adaptors/cache-adaptor.c b/atk-adaptor/adaptors/cache-adaptor.c
index cd93609..c2a6de9 100644
--- a/atk-adaptor/adaptors/cache-adaptor.c
+++ b/atk-adaptor/adaptors/cache-adaptor.c
@@ -70,6 +70,9 @@ get_toolkit_name (AtkObject *obj)
if (!toolkit_name)
toolkit_name = atk_get_toolkit_name ();
+ if (!toolkit_name)
+ return "no toolkit name set yet";
+
/* TODO: query object attributes */
return toolkit_name;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]