[tracker/sam/resource-no-autodispose] libtracker-sparql: Don't automatically call dispose() on TrackerResource



commit 149b148705c4735444ebe9d400dc3e483b99face
Author: Sam Thursfield <sam afuera me uk>
Date:   Mon Aug 26 16:00:45 2019 +0300

    libtracker-sparql: Don't automatically call dispose() on TrackerResource
    
    Just because we changed a property, does not mean we should delete the
    old value of that property, because it might still be in use somewhere
    else.
    
    See https://gitlab.gnome.org/GNOME/tracker/issues/127

 src/libtracker-sparql/tracker-resource.c | 2 --
 1 file changed, 2 deletions(-)
---
diff --git a/src/libtracker-sparql/tracker-resource.c b/src/libtracker-sparql/tracker-resource.c
index 9c9fd53aa..059289b78 100644
--- a/src/libtracker-sparql/tracker-resource.c
+++ b/src/libtracker-sparql/tracker-resource.c
@@ -117,8 +117,6 @@ tracker_resource_class_init (TrackerResourceClass *klass)
 static void
 free_value (GValue *value)
 {
-       if (G_VALUE_TYPE (value) == TRACKER_TYPE_RESOURCE)
-               g_object_run_dispose (g_value_get_object (value));
        g_value_unset (value);
        g_slice_free (GValue, value);
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]