[geary/wip/131-sent-mail: 14/14] App.ConversationMonitor: Don't force load ops to be local-only

[Michael Gratton <mjog src gnome org>]

commit 08c057345d047212d3e750acf725337e234796b3
Author: Michael Gratton <mike vee net>
Date:   Mon Aug 26 13:17:22 2019 +1000

    App.ConversationMonitor: Don't force load ops to be local-only
    
    In an attempt to prevent ConversationMonitor for blocking when a
    connection went bad, load operations were set to local-only when
    the remote was not open. This meant however that if the remote was in
    the process of being opened, that local-only would be set, and hence any
    incomplete messages would fail to be downloaded. Now that the Fill op
    now explicitly handles filling local-only by default, we can remove
    this.
    
    This ensures that when the conversation monitor is notified of new
    messages, but they are not yet fullly downloaded since the prefetcher
    is still running, that the messge will still show up.

 src/engine/app/app-conversation-monitor.vala | 12 ------------
 1 file changed, 12 deletions(-)
---
diff --git a/src/engine/app/app-conversation-monitor.vala b/src/engine/app/app-conversation-monitor.vala
index fe373a00..fc9f4f7b 100644
--- a/src/engine/app/app-conversation-monitor.vala
+++ b/src/engine/app/app-conversation-monitor.vala
@@ -423,10 +423,6 @@ public class Geary.App.ConversationMonitor : BaseObject {
         throws Error {
         notify_scan_started();
 
-        if (this.base_folder.get_open_state() != Folder.OpenState.REMOTE) {
-            flags |= Folder.ListFlags.LOCAL_ONLY;
-        }
-
         int load_count = 0;
         GLib.Error? scan_error = null;
         try {
@@ -464,10 +460,6 @@ public class Geary.App.ConversationMonitor : BaseObject {
         throws Error {
         notify_scan_started();
 
-        if (this.base_folder.get_open_state() != Folder.OpenState.REMOTE) {
-            flags |= Folder.ListFlags.LOCAL_ONLY;
-        }
-
         GLib.Error? scan_error = null;
         try {
             Gee.Collection<Geary.Email>? messages =
@@ -512,10 +504,6 @@ public class Geary.App.ConversationMonitor : BaseObject {
             );
             opened = true;
 
-            if (folder.get_open_state() != Folder.OpenState.REMOTE) {
-                flags |= Folder.ListFlags.LOCAL_ONLY;
-            }
-
             // First just get the bare minimum we need to determine if we even
             // care about the messages.
             emails = yield folder.list_email_by_sparse_id_async(