[orca] Chromium: Improve flat review presentation and reduce chattiness
- From: Joanmarie Diggs <joanied src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [orca] Chromium: Improve flat review presentation and reduce chattiness
- Date: Thu, 22 Aug 2019 23:49:39 +0000 (UTC)
commit e47f09d691aef5fe933b8355a29e88269e942c49
Author: Joanmarie Diggs <jdiggs igalia com>
Date: Thu Aug 22 19:49:03 2019 -0400
Chromium: Improve flat review presentation and reduce chattiness
src/orca/script_utilities.py | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
---
diff --git a/src/orca/script_utilities.py b/src/orca/script_utilities.py
index b61b52e7d..f69ef2834 100644
--- a/src/orca/script_utilities.py
+++ b/src/orca/script_utilities.py
@@ -1989,6 +1989,9 @@ class Utilities:
if role == pyatspi.ROLE_PUSH_BUTTON:
return [root]
+ if role == pyatspi.ROLE_TOGGLE_BUTTON:
+ return [root]
+
if role == pyatspi.ROLE_MENU_BAR:
self._selectedMenuBarMenu[hash(root)] = self.selectedMenuBarMenu(root)
@@ -2011,10 +2014,10 @@ class Utilities:
if visibleCells:
return visibleCells
- nonText = [pyatspi.ROLE_STATUS_BAR, pyatspi.ROLE_UNKNOWN, pyatspi.ROLE_REDUNDANT_OBJECT]
objects = []
- if (role == pyatspi.ROLE_PAGE_TAB and root.name) \
- or (role not in nonText and "Text" in pyatspi.listInterfaces(root)):
+ if role in [pyatspi.ROLE_PAGE_TAB, pyatspi.ROLE_IMAGE] and root.name:
+ objects.append(root)
+ elif "Text" in pyatspi.listInterfaces(root) and re.findall("\w+", root.queryText().getText(0, -1)):
objects.append(root)
for child in root:
@@ -2028,8 +2031,10 @@ class Utilities:
return objects
containers = [pyatspi.ROLE_FILLER,
+ pyatspi.ROLE_IMAGE,
pyatspi.ROLE_LIST_BOX,
pyatspi.ROLE_PANEL,
+ pyatspi.ROLE_SECTION,
pyatspi.ROLE_SCROLL_PANE,
pyatspi.ROLE_VIEWPORT]
if role in containers:
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]