[gjs: 1/7] tests: Reintroduce skipped tests that have been fixed



commit 34de4d44994e431982c78accb044eec6e8be55d2
Author: Philip Chimento <philip chimento gmail com>
Date:   Sun Aug 4 20:56:55 2019 -0700

    tests: Reintroduce skipped tests that have been fixed
    
    Many of these skipped tests were in fact waiting on GObject
    introspection testing API, which was added in 1.58.0. Some others have
    just been fixed along the way.

 installed-tests/js/testEverythingBasic.js        |  8 ++++----
 installed-tests/js/testEverythingEncapsulated.js |  2 +-
 installed-tests/js/testGIMarshalling.js          | 12 ++++++------
 3 files changed, 11 insertions(+), 11 deletions(-)
---
diff --git a/installed-tests/js/testEverythingBasic.js b/installed-tests/js/testEverythingBasic.js
index 0ea50d9a..9fda2780 100644
--- a/installed-tests/js/testEverythingBasic.js
+++ b/installed-tests/js/testEverythingBasic.js
@@ -421,12 +421,12 @@ describe('Life, the Universe and Everything', function () {
         expect(Regress.TestEnum.param(Regress.TestEnum.VALUE4)).toEqual('value4');
     });
 
-    xit('can be answered with GObject.set()', function () {
+    it('can be answered with GObject.set()', function () {
         let o = new Regress.TestObj();
         o.set({string: 'Answer', int: 42});
         expect(o.string).toBe('Answer');
         expect(o.int).toBe(42);
-    }).pend('https://gitlab.gnome.org/GNOME/gobject-introspection/issues/113');
+    });
 
     describe('Object properties on GtkBuilder-constructed objects', function () {
         let o1;
@@ -488,7 +488,7 @@ describe('Life, the Universe and Everything', function () {
         });
     });
 
-    xdescribe('Overridden properties on interfaces', function () {
+    describe('Overridden properties on interfaces', function () {
         it('set and get properly', function () {
             const o = new Regress.TestSubObj();
             o.number = 4;
@@ -505,7 +505,7 @@ describe('Life, the Universe and Everything', function () {
             const o = new Regress.TestSubObj({number: 4});
             expect(o.number).toEqual(4);
         });
-    }).pend('https://gitlab.gnome.org/GNOME/gobject-introspection/merge_requests/59');
+    });
 
     describe('Signal connection', function () {
         let o;
diff --git a/installed-tests/js/testEverythingEncapsulated.js 
b/installed-tests/js/testEverythingEncapsulated.js
index 2e6a993c..45d13cf3 100644
--- a/installed-tests/js/testEverythingEncapsulated.js
+++ b/installed-tests/js/testEverythingEncapsulated.js
@@ -234,7 +234,7 @@ describe('Introspected GObject', function () {
         expect(obj.name_conflict instanceof Function).toBeFalsy();
     });
 
-    xit('sets write-only properties', function () {
+    it('sets write-only properties', function () {
         expect(obj.int).not.toEqual(0);
         obj.write_only = true;
         expect(obj.int).toEqual(0);
diff --git a/installed-tests/js/testGIMarshalling.js b/installed-tests/js/testGIMarshalling.js
index 07224ef8..5fd785ee 100644
--- a/installed-tests/js/testGIMarshalling.js
+++ b/installed-tests/js/testGIMarshalling.js
@@ -504,7 +504,7 @@ describe('GValue', function () {
             .not.toThrow();
     });
 
-    xit('can have its type inferred as a foreign struct', function () {
+    it('can have its type inferred as a foreign struct', function () {
         let Cairo;
         try {
             Cairo = imports.cairo;
@@ -519,7 +519,7 @@ describe('GValue', function () {
             .not.toThrow();
         expect(() => GIMarshallingTests.gvalue_in_with_type(surface, Cairo.Surface))
             .not.toThrow();
-    }).pend('Errors out with "not a subclass of GObject_Boxed"');
+    });
 });
 
 describe('GType', function () {
@@ -775,13 +775,13 @@ describe('GObject properties', function () {
         expect(obj.some_gvalue).toEqual('foo');
     });
 
-    xit('gets a read-only property', function () {
+    it('gets a read-only property', function () {
         expect(obj.some_readonly).toEqual(42);
-    }).pend('https://gitlab.gnome.org/GNOME/gobject-introspection/merge_requests/32');
+    });
 
-    xit('throws when setting a read-only property', function () {
+    it('throws when setting a read-only property', function () {
         expect(() => (obj.some_readonly = 35)).toThrow();
-    }).pend('https://gitlab.gnome.org/GNOME/gobject-introspection/merge_requests/32');
+    });
 });
 
 describe('GDestroyNotify parameters', function () {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]