[grilo-plugins] grl-acoustid: Remove unnecessary variable release_group_id
- From: Victor Toso <victortoso src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [grilo-plugins] grl-acoustid: Remove unnecessary variable release_group_id
- Date: Wed, 14 Aug 2019 09:10:43 +0000 (UTC)
commit 5389e5b67c18110d2705dfbd705bf73a1fdba5c7
Author: Sumaid Syed <sumaidsyed gmail com>
Date: Tue Aug 13 10:05:55 2019 +0530
grl-acoustid: Remove unnecessary variable release_group_id
Earlier same variable release_group_id was assigned to both album id
and release group id.
Assign release group id and album id seperately with checks for their
corresponding keys instead of using same value for both of them
src/lua-factory/sources/grl-acoustid.lua | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
---
diff --git a/src/lua-factory/sources/grl-acoustid.lua b/src/lua-factory/sources/grl-acoustid.lua
index 4b402bcd..0acc4c26 100644
--- a/src/lua-factory/sources/grl-acoustid.lua
+++ b/src/lua-factory/sources/grl-acoustid.lua
@@ -119,7 +119,6 @@ function build_media(record, releasegroup)
local media = {}
local keys = grl.get_requested_keys ()
local album, release, artist
- local release_group_id
local creation_date = nil
media.title = keys.title and record.title or nil
@@ -127,9 +126,8 @@ function build_media(record, releasegroup)
album = releasegroup
media.album = keys.album and album.title or nil
- release_group_id = releasegroup.id or nil
- media.mb_album_id = release_group_id
- media.mb_release_group_id = release_group_id
+ media.mb_album_id = keys.mb_album_id and album.id or nil
+ media.mb_release_group_id = keys.mb_release_group_id and album.id or nil
-- FIXME: related-keys on lua sources are in the TODO list
-- https://bugzilla.gnome.org/show_bug.cgi?id=756203
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]