[gnome-online-accounts/wip/rishi/kerberos-potential-leak-sign-in-identity] kerberos: Avoid a potential memory leak



commit 7286d70f40f747c4ae1c7351cc8d7eacc241c065
Author: Debarshi Ray <debarshir gnome org>
Date:   Tue Aug 13 22:49:00 2019 +0200

    kerberos: Avoid a potential memory leak
    
    This isn't actually causing any memory leak at the moment because
    sign_in_identity_finish is always called and object_path is handed
    over to the caller to free. However, a future reorganization of the
    code might trigger a leak.

 src/goabackend/goakerberosprovider.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/src/goabackend/goakerberosprovider.c b/src/goabackend/goakerberosprovider.c
index 53f8311f..635e4661 100644
--- a/src/goabackend/goakerberosprovider.c
+++ b/src/goabackend/goakerberosprovider.c
@@ -1428,7 +1428,7 @@ sign_in_thread (GTask               *task,
   if (object_path == NULL)
     g_task_return_error (task, error);
   else
-    g_task_return_pointer (task, object_path, NULL);
+    g_task_return_pointer (task, object_path, g_free);
 }
 
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]