[balsa] Do not cast signal data using G_OBJECT(data)



commit b2fa84baa27c731b2c882d8fd2cfea0e218a27f6
Author: Peter Bloomfield <PeterBloomfield bellsouth net>
Date:   Mon Aug 12 15:08:04 2019 -0400

            Do not cast signal data using G_OBJECT(data)
    
            In calls to g_signal_connect_swapped(), do not cast data using
            G_OBJECT(data).
    
            The argument is a gpointer, so the cast is redundant.
    
            * src/filter-run-dialog.c (balsa_filter_run_dialog_init):

 ChangeLog               | 9 +++++++++
 src/filter-run-dialog.c | 6 +++---
 2 files changed, 12 insertions(+), 3 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 3d1a4cc69..a5f5d914a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2019-08-12  Peter Bloomfield  <pbloomfield bellsouth net>
+
+       In calls to g_signal_connect_swapped(), do not cast data using
+       G_OBJECT(data).
+
+       The argument is a gpointer, so the cast is redundant.
+
+       * src/filter-run-dialog.c (balsa_filter_run_dialog_init):
+
 2019-08-11  Peter Bloomfield  <pbloomfield bellsouth net>
 
        In calls to g_signal*(), do not cast object using
diff --git a/src/filter-run-dialog.c b/src/filter-run-dialog.c
index 55564dfaf..0a9afe934 100644
--- a/src/filter-run-dialog.c
+++ b/src/filter-run-dialog.c
@@ -358,7 +358,7 @@ balsa_filter_run_dialog_init(BalsaFilterRunDialog *p)
                                 _("Add selected filter to mailbox"));
     gtk_widget_set_sensitive(button, FALSE);
     g_signal_connect_swapped(button, "clicked",
-                             G_CALLBACK(fr_add_pressed), G_OBJECT(p));
+                             G_CALLBACK(fr_add_pressed), p);
     gtk_container_add(GTK_CONTAINER(bbox), button);
     /* Left/Remove button */
     p->remove_button = button =
@@ -368,7 +368,7 @@ balsa_filter_run_dialog_init(BalsaFilterRunDialog *p)
                                 _("Remove selected filter from mailbox"));
     gtk_widget_set_sensitive(button, FALSE);
     g_signal_connect_swapped(button, "clicked",
-                             G_CALLBACK(fr_remove_pressed), G_OBJECT(p));
+                             G_CALLBACK(fr_remove_pressed), p);
     gtk_container_add(GTK_CONTAINER(bbox), button);
 
     gtk_box_pack_start(GTK_BOX(hbox),bbox, FALSE, FALSE, 6);
@@ -426,7 +426,7 @@ balsa_filter_run_dialog_init(BalsaFilterRunDialog *p)
             gtk_button_new_with_mnemonic(_("A_pply Now!"));
     gtk_widget_set_sensitive(button, FALSE);
     g_signal_connect_swapped(button, "clicked",
-                             G_CALLBACK(fr_apply_now_pressed), G_OBJECT(p));
+                             G_CALLBACK(fr_apply_now_pressed), p);
     gtk_container_add(GTK_CONTAINER(bbox), button);
 
     p->filters_modified = FALSE;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]