[epiphany/mcatanzaro/evil-embed: 7/7] embed: do not inject fake load-changed event



commit d48116f39e7fc66acab7e53e6deb2818879e4865
Author: Michael Catanzaro <mcatanzaro gnome org>
Date:   Tue Aug 6 14:46:03 2019 -0500

    embed: do not inject fake load-changed event
    
    This cost me a lot of debugging time today, as it violates the
    expectations of EphyWebView. We should find a better way to do whatever
    this was trying to do. Unfortunately, it was probably added for a
    reason, so there's likely to be some regression regarding some UI
    element, but I'm really not sure what. Everything looks fine to me in my
    testing so far.
    
    This is from ce7ab1e34804d9f7529bed13267f4619c37e32d9.

 embed/ephy-embed.c | 5 -----
 1 file changed, 5 deletions(-)
---
diff --git a/embed/ephy-embed.c b/embed/ephy-embed.c
index 9957f5bc4..82e768af8 100644
--- a/embed/ephy-embed.c
+++ b/embed/ephy-embed.c
@@ -686,11 +686,6 @@ load_delayed_request_if_mapped (gpointer user_data)
   g_clear_object (&embed->delayed_request);
   g_clear_pointer (&embed->delayed_state, webkit_web_view_session_state_unref);
 
-  /* This is to allow UI elements watching load status to show that the page is
-   * loading as soon as possible.
-   */
-  g_signal_emit_by_name (web_view, "load-changed", WEBKIT_LOAD_STARTED);
-
   return G_SOURCE_REMOVE;
 }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]