[epiphany] adblock: Remove DNT row from preferences dialog

[Michael Catanzaro <mcatanzaro src gnome org>]

commit 1e02ee9404438fa2c3ed4f0ff1936abd175be3ae
Author: Adrian Perez de Castro <aperez igalia com>
Date:   Mon Jul 15 12:12:39 2019 +0300

    adblock: Remove DNT row from preferences dialog
    
    The setting is still stored, and honored by the Web process extension
    to determine whether to remove tracking parameters from URLs. This is
    too small a feature to expose in the preferences dialog.

 src/prefs-dialog.c                | 17 -----------------
 src/resources/gtk/prefs-dialog.ui | 15 ---------------
 2 files changed, 32 deletions(-)
---
diff --git a/src/prefs-dialog.c b/src/prefs-dialog.c
index b35f6d9a4..181901a40 100644
--- a/src/prefs-dialog.c
+++ b/src/prefs-dialog.c
@@ -119,8 +119,6 @@ struct _PrefsDialog {
   GtkWidget *no_third_party;
   GtkWidget *never;
   GtkWidget *remember_passwords_switch;
-  GtkWidget *do_not_track_row;
-  GtkWidget *do_not_track_switch;
   GtkWidget *clear_personal_data_button;
 
   /* language */
@@ -1003,8 +1001,6 @@ prefs_dialog_class_init (PrefsDialogClass *klass)
   gtk_widget_class_bind_template_child (widget_class, PrefsDialog, no_third_party);
   gtk_widget_class_bind_template_child (widget_class, PrefsDialog, never);
   gtk_widget_class_bind_template_child (widget_class, PrefsDialog, remember_passwords_switch);
-  gtk_widget_class_bind_template_child (widget_class, PrefsDialog, do_not_track_row);
-  gtk_widget_class_bind_template_child (widget_class, PrefsDialog, do_not_track_switch);
   gtk_widget_class_bind_template_child (widget_class, PrefsDialog, clear_personal_data_button);
 
   /* language */
@@ -1985,18 +1981,7 @@ setup_general_page (PrefsDialog *dialog)
                    dialog->adblock_allow_switch,
                    "active",
                    G_SETTINGS_BIND_DEFAULT);
-  g_settings_bind (web_settings,
-                   EPHY_PREFS_WEB_ENABLE_ADBLOCK,
-                   dialog->do_not_track_row,
-                   "sensitive",
-                   G_SETTINGS_BIND_DEFAULT);
 
-  g_settings_bind (web_settings,
-                   EPHY_PREFS_WEB_DO_NOT_TRACK,
-                   dialog->do_not_track_switch,
-                   "active",
-                   /* Teensy hack: don't override the previous binding. */
-                   G_SETTINGS_BIND_NO_SENSITIVITY);
   g_settings_bind (web_settings,
                    EPHY_PREFS_WEB_ENABLE_SMOOTH_SCROLLING,
                    dialog->enable_smooth_scrolling_switch,
@@ -2389,8 +2374,6 @@ prefs_dialog_init (PrefsDialog *dialog)
                           mode != EPHY_EMBED_SHELL_MODE_APPLICATION);
   gtk_widget_set_visible (dialog->browsing_box,
                           mode != EPHY_EMBED_SHELL_MODE_APPLICATION);
-  gtk_widget_set_visible (dialog->do_not_track_row,
-                          mode != EPHY_EMBED_SHELL_MODE_APPLICATION);
   gtk_widget_set_visible (dialog->reader_mode_box,
                           mode != EPHY_EMBED_SHELL_MODE_APPLICATION);
 
diff --git a/src/resources/gtk/prefs-dialog.ui b/src/resources/gtk/prefs-dialog.ui
index ac04087ec..5dd4baad4 100644
--- a/src/resources/gtk/prefs-dialog.ui
+++ b/src/resources/gtk/prefs-dialog.ui
@@ -348,21 +348,6 @@
                         </child>
                       </object>
                     </child>
-                    <child>
-                      <object class="HdyActionRow" id="do_not_track_row">
-                        <property name="activatable_widget">do_not_track_switch</property>
-                        <property name="margin-start">24</property>
-                        <property name="title" translatable="yes">Try to block web _trackers</property>
-                        <property name="use_underline">True</property>
-                        <property name="visible">True</property>
-                        <child type="action">
-                          <object class="GtkSwitch" id="do_not_track_switch">
-                            <property name="valign">center</property>
-                            <property name="visible">True</property>
-                          </object>
-                        </child>
-                      </object>
-                    </child>
                     <child>
                       <object class="HdyActionRow">
                         <property name="activatable_widget">popups_allow_switch</property>