[glade/wip/chergert/fix-deprecations: 3/3] gladeui: remove implicit cast in assignment



commit 143ab6603e516d7d08261e718644832609b71de5
Author: Christian Hergert <chergert redhat com>
Date:   Mon Aug 5 15:01:41 2019 -0700

    gladeui: remove implicit cast in assignment
    
    It's considered an anti-pattern in the GNOME code-base's now to use
    implicity asignment through the void* cast in g_object_ref, as it now
    propagates the type of param0 to the return type.
    
    This fixes that with an explicit cast before we try to ref the object.

 gladeui/glade-widget.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/gladeui/glade-widget.c b/gladeui/glade-widget.c
index 74e2c407..1efea6cc 100644
--- a/gladeui/glade-widget.c
+++ b/gladeui/glade-widget.c
@@ -1831,7 +1831,7 @@ glade_widget_extract_children (GladeWidget *gwidget)
           else
             {
               /* need to handle placeholders by hand here */
-              extract->placeholder = g_object_ref (child);
+              extract->placeholder = g_object_ref (GTK_WIDGET (child));
               glade_widget_adaptor_remove (gwidget->priv->adaptor,
                                            gwidget->priv->object, child);
             }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]