[gnome-boxes] unattended-file: Prefer cdrom over floppy as injection method



commit ac31935617939c6a247660ebb88b68db80c9fe26
Author: Fabiano FidĂȘncio <fidencio redhat com>
Date:   Tue Jun 11 13:39:34 2019 +0200

    unattended-file: Prefer cdrom over floppy as injection method
    
    Instead of using "floppy" as the way to perform unattended installations
    for Windoes, let's prefer using "cdrom" instead.
    
    The main reasons behind this change are:
    - VMs using q35 may have floppy device disabled in some systems;
    - We can drop mtools dependency;
    
    Generating the ISO depends on genisoimage, tho. However, it's not a big
    deal as genisoimage is already a GNOME Boxes dependency.
    
    Signed-off-by: Fabiano FidĂȘncio <fidencio redhat com>

 src/unattended-file.vala | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/src/unattended-file.vala b/src/unattended-file.vala
index fc25f443..883e6712 100644
--- a/src/unattended-file.vala
+++ b/src/unattended-file.vala
@@ -123,10 +123,10 @@ public UnattendedScriptFile (UnattendedInstaller installer,
             injection_method = InstallScriptInjectionMethod.INITRD;
         else if (InstallScriptInjectionMethod.DISK in injection_methods)
             injection_method = InstallScriptInjectionMethod.DISK;
-        else if (InstallScriptInjectionMethod.FLOPPY in injection_methods)
-            injection_method = InstallScriptInjectionMethod.FLOPPY;
         else if (InstallScriptInjectionMethod.CDROM in injection_methods)
             injection_method = InstallScriptInjectionMethod.CDROM;
+        else if (InstallScriptInjectionMethod.FLOPPY in injection_methods)
+            injection_method = InstallScriptInjectionMethod.FLOPPY;
         else
             throw new GLib.IOError.NOT_SUPPORTED ("No supported injection method available.");
     }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]