[evolution] M!39 - ECell::draw: always display text in contrasting color



commit c58163f68a6d47b0097ef3ebc9e716cdbd9ac5e3
Author: Дилян Палаузов <git-dpa aegee org>
Date:   Fri Aug 2 10:22:35 2019 +0000

    M!39 - ECell::draw: always display text in contrasting color
    
    When a row is displayed with dark background, the text color used for the row
    is white.  When a cell from the row is selected, the text color remains white
    in the selected cell and in the whole line.  This makes reading the text from
    any cell of the selected row easy.
    
    When a row is displayed with light color, the text color is black.  When this
    row is selected, the text color for the row is changed to white and the text of
    the selected cell is kept black.  Reading the text from the selected row, that
    is outside the selected cell is hard, as there is no contrast.
    
    With this change, the cells are displayed always with contrasting color.
    
    Closes https://gitlab.gnome.org/GNOME/evolution/merge_requests/39

 src/e-util/e-cell-text.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/src/e-util/e-cell-text.c b/src/e-util/e-cell-text.c
index 5c5be50a99..65adf2abb6 100644
--- a/src/e-util/e-cell-text.c
+++ b/src/e-util/e-cell-text.c
@@ -766,7 +766,7 @@ ect_draw (ECellView *ecell_view,
                        e_table_model_free_value (ecell_view->e_table_model, ect->color_column, color_spec);
        }
 
-       if (!color_overwritten && !selected && ect->bg_color_column != -1) {
+       if (!color_overwritten && ect->bg_color_column != -1) {
                gchar *color_spec;
 
                /* if the background color is overwritten and the text color is not, then


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]