[gimp/wip/nielsdg/g-object-notify: 20/20] Start using g_object_notify_by_pspec()

[Michael Natterer <mitch src gnome org>]

commit 529aa743ddb96ca5b14c2967bcaaafc9f4e7820a
Author: Niels De Graef <nielsdegraef gmail com>
Date:   Sat Aug 3 08:23:10 2019 +0200

    Start using g_object_notify_by_pspec()
    
    `g_object_notify()` actually takes a global lock to look up the property
    by its name, which means there is a performance hit (albeit tiny) every
    time this function is called. For this reason, always try to use
    `g_object_notify_by_pspec()` instead.

 app/core/gimpobject.c | 26 ++++++++++++++------------
 1 file changed, 14 insertions(+), 12 deletions(-)
---
diff --git a/app/core/gimpobject.c b/app/core/gimpobject.c
index 3399647662..cf4450d2e7 100644
--- a/app/core/gimpobject.c
+++ b/app/core/gimpobject.c
@@ -43,10 +43,10 @@ enum
 enum
 {
   PROP_0,
-  PROP_NAME
+  PROP_NAME,
+  N_PROPS
 };
 
-
 struct _GimpObjectPrivate
 {
   gchar *name;
@@ -78,6 +78,7 @@ G_DEFINE_TYPE_WITH_CODE (GimpObject, gimp_object, G_TYPE_OBJECT,
 #define parent_class gimp_object_parent_class
 
 static guint object_signals[LAST_SIGNAL] = { 0 };
+static GParamSpec *object_props[N_PROPS] = { NULL, };
 
 
 static void
@@ -115,12 +116,13 @@ gimp_object_class_init (GimpObjectClass *klass)
   klass->name_changed        = NULL;
   klass->get_memsize         = gimp_object_real_get_memsize;
 
-  g_object_class_install_property (object_class, PROP_NAME,
-                                   g_param_spec_string ("name",
-                                                        NULL, NULL,
-                                                        NULL,
-                                                        GIMP_PARAM_READWRITE |
-                                                        G_PARAM_CONSTRUCT));
+  object_props[PROP_NAME] = g_param_spec_string ("name",
+                                                 NULL, NULL,
+                                                 NULL,
+                                                 GIMP_PARAM_READWRITE |
+                                                 G_PARAM_CONSTRUCT);
+
+  g_object_class_install_properties (object_class, N_PROPS, object_props);
 }
 
 static void
@@ -229,7 +231,7 @@ gimp_object_set_name (GimpObject  *object,
   object->p->static_name = FALSE;
 
   gimp_object_name_changed (object);
-  g_object_notify (G_OBJECT (object), "name");
+  g_object_notify_by_pspec (G_OBJECT (object), object_props[PROP_NAME]);
 }
 
 /**
@@ -256,7 +258,7 @@ gimp_object_set_name_safe (GimpObject  *object,
   object->p->static_name = FALSE;
 
   gimp_object_name_changed (object);
-  g_object_notify (G_OBJECT (object), "name");
+  g_object_notify_by_pspec (G_OBJECT (object), object_props[PROP_NAME]);
 }
 
 void
@@ -274,7 +276,7 @@ gimp_object_set_static_name (GimpObject  *object,
   object->p->static_name = TRUE;
 
   gimp_object_name_changed (object);
-  g_object_notify (G_OBJECT (object), "name");
+  g_object_notify_by_pspec (G_OBJECT (object), object_props[PROP_NAME]);
 }
 
 void
@@ -295,7 +297,7 @@ gimp_object_take_name (GimpObject *object,
   object->p->static_name = FALSE;
 
   gimp_object_name_changed (object);
-  g_object_notify (G_OBJECT (object), "name");
+  g_object_notify_by_pspec (G_OBJECT (object), object_props[PROP_NAME]);
 }
 
 /**