[gimp] Revert "libgimp: move _gimp_read_expect_msg() back to gimp.c"
- From: Michael Natterer <mitch src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gimp] Revert "libgimp: move _gimp_read_expect_msg() back to gimp.c"
- Date: Sat, 3 Aug 2019 10:53:26 +0000 (UTC)
commit 3dd79f42c30f4915726c51bb50de9e7cb75f4c6a
Author: Michael Natterer <mitch gimp org>
Date: Sat Aug 3 12:33:36 2019 +0200
Revert "libgimp: move _gimp_read_expect_msg() back to gimp.c"
This reverts commit 366047f423b423c46cb916ec9bd1ac361b44fa0a.
libgimp/gimp-private.h | 1 -
libgimp/gimp.c | 32 --------------------------------
libgimp/gimplegacy.c | 32 +++++++++++++++++++++++++++++---
libgimp/gimpplugin-private.c | 10 ++++++----
libgimp/gimpplugin-private.h | 20 +++++++++-----------
5 files changed, 44 insertions(+), 51 deletions(-)
---
diff --git a/libgimp/gimp-private.h b/libgimp/gimp-private.h
index d3ecc4ac15..4920453fe6 100644
--- a/libgimp/gimp-private.h
+++ b/libgimp/gimp-private.h
@@ -35,7 +35,6 @@ void _gimp_config (GPConfig *config);
void _gimp_loop (GimpRunProc run_proc);
void _gimp_read_expect_msg (GimpWireMessage *msg,
gint type);
-void _gimp_process_message (GimpWireMessage *msg);
G_END_DECLS
diff --git a/libgimp/gimp.c b/libgimp/gimp.c
index 36c99d52c0..6084329ffc 100644
--- a/libgimp/gimp.c
+++ b/libgimp/gimp.c
@@ -820,38 +820,6 @@ gimp_quit (void)
exit (EXIT_SUCCESS);
}
-void
-_gimp_read_expect_msg (GimpWireMessage *msg,
- gint type)
-{
- while (TRUE)
- {
- if (! gimp_wire_read_msg (_gimp_readchannel, msg, NULL))
- gimp_quit ();
-
- if (msg->type == type)
- return; /* up to the caller to call wire_destroy() */
-
- if (msg->type == GP_TEMP_PROC_RUN || msg->type == GP_QUIT)
- {
- if (PLUG_IN)
- {
- _gimp_plug_in_process_message (PLUG_IN, msg);
- }
- else
- {
- _gimp_process_message (msg);
- }
- }
- else
- {
- g_error ("unexpected message: %d", msg->type);
- }
-
- gimp_wire_destroy (msg);
- }
-}
-
GimpValueArray *
gimp_run_procedure_with_array (const gchar *name,
GimpValueArray *arguments)
diff --git a/libgimp/gimplegacy.c b/libgimp/gimplegacy.c
index 7b3ca1740c..c18c089625 100644
--- a/libgimp/gimplegacy.c
+++ b/libgimp/gimplegacy.c
@@ -45,6 +45,7 @@
**/
+static void gimp_process_message (GimpWireMessage *msg);
static void gimp_single_message (void);
static gboolean gimp_extension_read (GIOChannel *channel,
GIOCondition condition,
@@ -439,6 +440,31 @@ gimp_extension_process (guint timeout)
#endif
}
+void
+_gimp_read_expect_msg (GimpWireMessage *msg,
+ gint type)
+{
+ while (TRUE)
+ {
+ if (! gimp_wire_read_msg (_gimp_readchannel, msg, NULL))
+ gimp_quit ();
+
+ if (msg->type == type)
+ return; /* up to the caller to call wire_destroy() */
+
+ if (msg->type == GP_TEMP_PROC_RUN || msg->type == GP_QUIT)
+ {
+ gimp_process_message (msg);
+ }
+ else
+ {
+ g_error ("unexpected message: %d", msg->type);
+ }
+
+ gimp_wire_destroy (msg);
+ }
+}
+
/**
* gimp_run_procedure: (skip)
* @name: the name of the procedure to run
@@ -996,8 +1022,8 @@ gimp_plugin_icon_register (const gchar *procedure_name,
/* private functions */
-void
-_gimp_process_message (GimpWireMessage *msg)
+static void
+gimp_process_message (GimpWireMessage *msg)
{
switch (msg->type)
{
@@ -1042,7 +1068,7 @@ gimp_single_message (void)
if (! gimp_wire_read_msg (_gimp_readchannel, &msg, NULL))
gimp_quit ();
- _gimp_process_message (&msg);
+ gimp_process_message (&msg);
gimp_wire_destroy (&msg);
}
diff --git a/libgimp/gimpplugin-private.c b/libgimp/gimpplugin-private.c
index e4f9128ff1..37297631a3 100644
--- a/libgimp/gimpplugin-private.c
+++ b/libgimp/gimpplugin-private.c
@@ -36,6 +36,8 @@
static void gimp_plug_in_register (GimpPlugIn *plug_in,
GList *procedures);
static void gimp_plug_in_loop (GimpPlugIn *plug_in);
+static void gimp_plug_in_process_message (GimpPlugIn *plug_in,
+ GimpWireMessage *msg);
static void gimp_plug_in_proc_run (GimpPlugIn *plug_in,
GPProcRun *proc_run);
static void gimp_plug_in_temp_proc_run (GimpPlugIn *plug_in,
@@ -226,14 +228,14 @@ _gimp_plug_in_single_message (GimpPlugIn *plug_in)
if (! gimp_wire_read_msg (_gimp_readchannel, &msg, NULL))
gimp_quit ();
- _gimp_plug_in_process_message (plug_in, &msg);
+ gimp_plug_in_process_message (plug_in, &msg);
gimp_wire_destroy (&msg);
}
-void
-_gimp_plug_in_process_message (GimpPlugIn *plug_in,
- GimpWireMessage *msg)
+static void
+gimp_plug_in_process_message (GimpPlugIn *plug_in,
+ GimpWireMessage *msg)
{
switch (msg->type)
{
diff --git a/libgimp/gimpplugin-private.h b/libgimp/gimpplugin-private.h
index bf0edf4aa0..66fe8acba8 100644
--- a/libgimp/gimpplugin-private.h
+++ b/libgimp/gimpplugin-private.h
@@ -49,17 +49,15 @@ struct _GimpPlugInPrivate
};
-void _gimp_plug_in_query (GimpPlugIn *plug_in);
-void _gimp_plug_in_init (GimpPlugIn *plug_in);
-void _gimp_plug_in_run (GimpPlugIn *plug_in);
-void _gimp_plug_in_quit (GimpPlugIn *plug_in);
-
-gboolean _gimp_plug_in_extension_read (GIOChannel *channel,
- GIOCondition condition,
- gpointer data);
-void _gimp_plug_in_single_message (GimpPlugIn *plug_in);
-void _gimp_plug_in_process_message (GimpPlugIn *plug_in,
- GimpWireMessage *msg);
+void _gimp_plug_in_query (GimpPlugIn *plug_in);
+void _gimp_plug_in_init (GimpPlugIn *plug_in);
+void _gimp_plug_in_run (GimpPlugIn *plug_in);
+void _gimp_plug_in_quit (GimpPlugIn *plug_in);
+
+gboolean _gimp_plug_in_extension_read (GIOChannel *channel,
+ GIOCondition condition,
+ gpointer data);
+void _gimp_plug_in_single_message (GimpPlugIn *plug_in);
G_END_DECLS
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]