[mutter/wip/nielsdg/cleanup-clutter-marshal: 14/14] clutter: Use va_marshaller for Actor signals
- From: Niels De Graef <nielsdg src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [mutter/wip/nielsdg/cleanup-clutter-marshal: 14/14] clutter: Use va_marshaller for Actor signals
- Date: Thu, 1 Aug 2019 07:00:48 +0000 (UTC)
commit b01d7697d38e04aa97d2e783ad24d6a4c73ee4a1
Author: Niels De Graef <nielsdegraef gmail com>
Date: Thu Aug 1 08:55:51 2019 +0200
clutter: Use va_marshaller for Actor signals
If possible, GLib will try to use the va_marshaller to pass the signal
arguments, rather than unboxing into and out of a `GValue`. This is much
more performant and especially good for often-thrown signals.
The original bug even mentions Clutter performance issues as a drive to
implement the va_marshaller in GLib (see
https://bugzilla.gnome.org/show_bug.cgi?id=661140).
https://gitlab.gnome.org/GNOME/mutter/merge_requests/700
clutter/clutter/clutter-actor.c | 42 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 42 insertions(+)
---
diff --git a/clutter/clutter/clutter-actor.c b/clutter/clutter/clutter-actor.c
index 3bf16b3b2..48f10bae0 100644
--- a/clutter/clutter/clutter-actor.c
+++ b/clutter/clutter/clutter-actor.c
@@ -8114,6 +8114,9 @@ clutter_actor_class_init (ClutterActorClass *klass)
G_TYPE_BOOLEAN, 2,
CLUTTER_TYPE_ACTOR,
CLUTTER_TYPE_PAINT_VOLUME);
+ g_signal_set_va_marshaller (actor_signals[QUEUE_REDRAW],
+ G_TYPE_FROM_CLASS (object_class),
+ _clutter_marshal_BOOLEAN__OBJECT_BOXEDv);
/**
* ClutterActor::queue-relayout:
@@ -8165,6 +8168,9 @@ clutter_actor_class_init (ClutterActorClass *klass)
_clutter_marshal_BOOLEAN__BOXED,
G_TYPE_BOOLEAN, 1,
CLUTTER_TYPE_EVENT | G_SIGNAL_TYPE_STATIC_SCOPE);
+ g_signal_set_va_marshaller (actor_signals[EVENT],
+ G_TYPE_FROM_CLASS (object_class),
+ _clutter_marshal_BOOLEAN__BOXEDv);
/**
* ClutterActor::button-press-event:
* @actor: the actor which received the event
@@ -8187,6 +8193,9 @@ clutter_actor_class_init (ClutterActorClass *klass)
_clutter_marshal_BOOLEAN__BOXED,
G_TYPE_BOOLEAN, 1,
CLUTTER_TYPE_EVENT | G_SIGNAL_TYPE_STATIC_SCOPE);
+ g_signal_set_va_marshaller (actor_signals[BUTTON_PRESS_EVENT],
+ G_TYPE_FROM_CLASS (object_class),
+ _clutter_marshal_BOOLEAN__BOXEDv);
/**
* ClutterActor::button-release-event:
* @actor: the actor which received the event
@@ -8209,6 +8218,9 @@ clutter_actor_class_init (ClutterActorClass *klass)
_clutter_marshal_BOOLEAN__BOXED,
G_TYPE_BOOLEAN, 1,
CLUTTER_TYPE_EVENT | G_SIGNAL_TYPE_STATIC_SCOPE);
+ g_signal_set_va_marshaller (actor_signals[BUTTON_RELEASE_EVENT],
+ G_TYPE_FROM_CLASS (object_class),
+ _clutter_marshal_BOOLEAN__BOXEDv);
/**
* ClutterActor::scroll-event:
* @actor: the actor which received the event
@@ -8231,6 +8243,9 @@ clutter_actor_class_init (ClutterActorClass *klass)
_clutter_marshal_BOOLEAN__BOXED,
G_TYPE_BOOLEAN, 1,
CLUTTER_TYPE_EVENT | G_SIGNAL_TYPE_STATIC_SCOPE);
+ g_signal_set_va_marshaller (actor_signals[SCROLL_EVENT],
+ G_TYPE_FROM_CLASS (object_class),
+ _clutter_marshal_BOOLEAN__BOXEDv);
/**
* ClutterActor::key-press-event:
* @actor: the actor which received the event
@@ -8253,6 +8268,9 @@ clutter_actor_class_init (ClutterActorClass *klass)
_clutter_marshal_BOOLEAN__BOXED,
G_TYPE_BOOLEAN, 1,
CLUTTER_TYPE_EVENT | G_SIGNAL_TYPE_STATIC_SCOPE);
+ g_signal_set_va_marshaller (actor_signals[KEY_PRESS_EVENT],
+ G_TYPE_FROM_CLASS (object_class),
+ _clutter_marshal_BOOLEAN__BOXEDv);
/**
* ClutterActor::key-release-event:
* @actor: the actor which received the event
@@ -8276,6 +8294,9 @@ clutter_actor_class_init (ClutterActorClass *klass)
_clutter_marshal_BOOLEAN__BOXED,
G_TYPE_BOOLEAN, 1,
CLUTTER_TYPE_EVENT | G_SIGNAL_TYPE_STATIC_SCOPE);
+ g_signal_set_va_marshaller (actor_signals[KEY_RELEASE_EVENT],
+ G_TYPE_FROM_CLASS (object_class),
+ _clutter_marshal_BOOLEAN__BOXEDv);
/**
* ClutterActor::motion-event:
* @actor: the actor which received the event
@@ -8298,6 +8319,9 @@ clutter_actor_class_init (ClutterActorClass *klass)
_clutter_marshal_BOOLEAN__BOXED,
G_TYPE_BOOLEAN, 1,
CLUTTER_TYPE_EVENT | G_SIGNAL_TYPE_STATIC_SCOPE);
+ g_signal_set_va_marshaller (actor_signals[MOTION_EVENT],
+ G_TYPE_FROM_CLASS (object_class),
+ _clutter_marshal_BOOLEAN__BOXEDv);
/**
* ClutterActor::key-focus-in:
@@ -8352,6 +8376,9 @@ clutter_actor_class_init (ClutterActorClass *klass)
_clutter_marshal_BOOLEAN__BOXED,
G_TYPE_BOOLEAN, 1,
CLUTTER_TYPE_EVENT | G_SIGNAL_TYPE_STATIC_SCOPE);
+ g_signal_set_va_marshaller (actor_signals[ENTER_EVENT],
+ G_TYPE_FROM_CLASS (object_class),
+ _clutter_marshal_BOOLEAN__BOXEDv);
/**
* ClutterActor::leave-event:
@@ -8374,6 +8401,9 @@ clutter_actor_class_init (ClutterActorClass *klass)
_clutter_marshal_BOOLEAN__BOXED,
G_TYPE_BOOLEAN, 1,
CLUTTER_TYPE_EVENT | G_SIGNAL_TYPE_STATIC_SCOPE);
+ g_signal_set_va_marshaller (actor_signals[LEAVE_EVENT],
+ G_TYPE_FROM_CLASS (object_class),
+ _clutter_marshal_BOOLEAN__BOXEDv);
/**
* ClutterActor::captured-event:
@@ -8402,6 +8432,9 @@ clutter_actor_class_init (ClutterActorClass *klass)
_clutter_marshal_BOOLEAN__BOXED,
G_TYPE_BOOLEAN, 1,
CLUTTER_TYPE_EVENT | G_SIGNAL_TYPE_STATIC_SCOPE);
+ g_signal_set_va_marshaller (actor_signals[CAPTURED_EVENT],
+ G_TYPE_FROM_CLASS (object_class),
+ _clutter_marshal_BOOLEAN__BOXEDv);
/**
* ClutterActor::paint:
@@ -8527,6 +8560,9 @@ clutter_actor_class_init (ClutterActorClass *klass)
G_TYPE_NONE, 2,
CLUTTER_TYPE_ACTOR_BOX | G_SIGNAL_TYPE_STATIC_SCOPE,
CLUTTER_TYPE_ALLOCATION_FLAGS);
+ g_signal_set_va_marshaller (actor_signals[ALLOCATION_CHANGED],
+ G_TYPE_FROM_CLASS (object_class),
+ _clutter_marshal_VOID__BOXED_FLAGSv);
/**
* ClutterActor::transitions-completed:
@@ -8570,6 +8606,9 @@ clutter_actor_class_init (ClutterActorClass *klass)
G_TYPE_NONE, 2,
G_TYPE_STRING,
G_TYPE_BOOLEAN);
+ g_signal_set_va_marshaller (actor_signals[TRANSITION_STOPPED],
+ G_TYPE_FROM_CLASS (object_class),
+ _clutter_marshal_VOID__STRING_BOOLEANv);
/**
* ClutterActor::touch-event:
@@ -8593,6 +8632,9 @@ clutter_actor_class_init (ClutterActorClass *klass)
_clutter_marshal_BOOLEAN__BOXED,
G_TYPE_BOOLEAN, 1,
CLUTTER_TYPE_EVENT | G_SIGNAL_TYPE_STATIC_SCOPE);
+ g_signal_set_va_marshaller (actor_signals[TOUCH_EVENT],
+ G_TYPE_FROM_CLASS (object_class),
+ _clutter_marshal_BOOLEAN__BOXEDv);
}
static void
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]