[epiphany/mcatanzaro/#691] history-manager: avoid critical when deleting URLs not tracked by sync
- From: Michael Catanzaro <mcatanzaro src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [epiphany/mcatanzaro/#691] history-manager: avoid critical when deleting URLs not tracked by sync
- Date: Mon, 29 Apr 2019 21:41:05 +0000 (UTC)
commit c8b3f008242197b8d24b6e5d5c6b9a7b8d1c47e3
Author: Michael Catanzaro <mcatanzaro igalia com>
Date: Mon Apr 29 16:39:45 2019 -0500
history-manager: avoid critical when deleting URLs not tracked by sync
Fixes #691
lib/sync/ephy-history-manager.c | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
---
diff --git a/lib/sync/ephy-history-manager.c b/lib/sync/ephy-history-manager.c
index 31914357d..547ce40cf 100644
--- a/lib/sync/ephy-history-manager.c
+++ b/lib/sync/ephy-history-manager.c
@@ -91,9 +91,11 @@ url_visited_cb (EphyHistoryService *service,
{
EphyHistoryRecord *record;
- record = ephy_history_record_new (url->sync_id, url->title, url->url, url->last_visit_time);
- g_signal_emit_by_name (self, "synchronizable-modified", record, TRUE);
- g_object_unref (record);
+ if (url->sync_id) {
+ record = ephy_history_record_new (url->sync_id, url->title, url->url, url->last_visit_time);
+ g_signal_emit_by_name (self, "synchronizable-modified", record, TRUE);
+ g_object_unref (record);
+ }
}
static void
@@ -103,9 +105,11 @@ url_deleted_cb (EphyHistoryService *service,
{
EphyHistoryRecord *record;
- record = ephy_history_record_new (url->sync_id, url->title, url->url, url->last_visit_time);
- g_signal_emit_by_name (self, "synchronizable-deleted", record);
- g_object_unref (record);
+ if (url->sync_id) {
+ record = ephy_history_record_new (url->sync_id, url->title, url->url, url->last_visit_time);
+ g_signal_emit_by_name (self, "synchronizable-deleted", record);
+ g_object_unref (record);
+ }
}
static void
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]