[gtk/wip/matthiasc/popup4: 65/121] surface: Simplify some code



commit 23a18ceec39ffd4f564ca305b05bd704c3997323
Author: Matthias Clasen <mclasen redhat com>
Date:   Sat Mar 23 09:35:14 2019 -0400

    surface: Simplify some code
    
    Fold gdk_surface_process_updates_recurse into its
    only caller. There is no recursion here anymore.

 gdk/gdksurface.c | 19 ++-----------------
 1 file changed, 2 insertions(+), 17 deletions(-)
---
diff --git a/gdk/gdksurface.c b/gdk/gdksurface.c
index 3b3095201a..f70b73a0e4 100644
--- a/gdk/gdksurface.c
+++ b/gdk/gdksurface.c
@@ -1110,22 +1110,6 @@ gdk_surface_schedule_update (GdkSurface *surface)
                                    GDK_FRAME_CLOCK_PHASE_PAINT);
 }
 
-static void
-gdk_surface_process_updates_recurse (GdkSurface *surface,
-                                     cairo_region_t *expose_region)
-{
-  gboolean handled;
-
-  if (surface->destroyed)
-    return;
-
-  /* Paint the surface before the children, clipped to the surface region */
-  g_signal_emit (surface, signals[RENDER], 0, expose_region, &handled);
-}
-
-/* Process and remove any invalid area on the native surface by creating
- * expose events for the surface and all non-native descendants.
- */
 static void
 gdk_surface_process_updates_internal (GdkSurface *surface)
 {
@@ -1148,10 +1132,11 @@ gdk_surface_process_updates_internal (GdkSurface *surface)
       if (gdk_surface_is_viewable (surface))
         {
           cairo_region_t *expose_region;
+          gboolean handled;
 
           expose_region = cairo_region_copy (surface->active_update_area);
 
-          gdk_surface_process_updates_recurse (surface, expose_region);
+          g_signal_emit (surface, signals[RENDER], 0, expose_region, &handled);
 
           cairo_region_destroy (expose_region);
         }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]