[seahorse/wip/nielsdg/fix-epiphany-segfault] gkr: Fix a crash for some Epiphany passwords
- From: Niels De Graef <nielsdg src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [seahorse/wip/nielsdg/fix-epiphany-segfault] gkr: Fix a crash for some Epiphany passwords
- Date: Thu, 25 Apr 2019 13:21:23 +0000 (UTC)
commit ae67176ea320331a2e3cedcf59dffca8fd3eba52
Author: Niels De Graef <niels degraef barco com>
Date: Thu Apr 25 15:18:41 2019 +0200
gkr: Fix a crash for some Epiphany passwords
The NULL-check in `GkrItem.epiphany_custom()` checked the wrong
variable, making it possible that we were still passing on a NULL string
as a username to `GLib.Markup.escape_text()`
Fixes https://gitlab.gnome.org/GNOME/seahorse/issues/225
gkr/gkr-item.vala | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/gkr/gkr-item.vala b/gkr/gkr-item.vala
index 51334f34..e5f0c2b4 100644
--- a/gkr/gkr-item.vala
+++ b/gkr/gkr-item.vala
@@ -376,7 +376,7 @@ private void epiphany_custom(string? display,
info.label = uri;
var username = get_attribute_string(attrs, "username");
- if (uri != null)
+ if (username != null)
info.details = Markup.escape_text(username);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]