[gnome-music/wip/jfelder/mpris-fix-activateplaylist: 16/17] playlistview: Do not manually emit row-activated signal



commit fa0311e2fb7a81dbf83051a34c6ac08a747795da
Author: Jean Felder <jfelder src gnome org>
Date:   Mon Apr 15 15:45:40 2019 +0200

    playlistview: Do not manually emit row-activated signal
    
    "row-activated" of a GtkListBox is not an action signal, it should not
    be emitted manually.
    
    Use "activate" signal from the row instead.

 gnomemusic/views/playlistview.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/gnomemusic/views/playlistview.py b/gnomemusic/views/playlistview.py
index e43eee4b..257bac08 100644
--- a/gnomemusic/views/playlistview.py
+++ b/gnomemusic/views/playlistview.py
@@ -315,7 +315,7 @@ class PlaylistView(BaseView):
 
         if len(self._sidebar) == 1:
             self._sidebar.select_row(row)
-            self._sidebar.emit('row-activated', row)
+            row.emit('activate')
 
     @log
     def _on_song_validated(self, player, index, status):
@@ -497,7 +497,7 @@ class PlaylistView(BaseView):
 
                         handler = self.connect('playlist-songs-loaded',
                                                songs_loaded_callback)
-                        self._sidebar.emit('row-activated', row)
+                        row.emit('activate')
 
                     return
 
@@ -679,7 +679,7 @@ class PlaylistView(BaseView):
 
         if row_next:
             self._sidebar.select_row(row_next)
-            self._sidebar.emit('row-activated', row_next)
+            row_next.emit('activate')
 
         self._create_notification(
             PlaylistNotification.Type.PLAYLIST, playlist_id)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]