[folks/wip/nielsdg/drop-autotools: 2/2] Remove the various calls to libtool



commit bd50ec501cc7040757e1bd6962972b2a3d9e1d73
Author: Niels De Graef <nielsdegraef gmail com>
Date:   Tue Apr 23 07:47:08 2019 +0200

    Remove the various calls to libtool
    
    This was needed in the automake build, but since we've added support for
    Meson now, we can just rely on the `--gdb` option of `meson test` to
    start up a gdb instance for us (and G_DEBUG=fatal-warnings to let us
    break at the correct point).
    
    https://gitlab.gnome.org/GNOME/folks/merge_requests/13

 tests/lib/telepathy/contactlist/backend.c |  7 +------
 tests/lib/test-case.vala                  | 22 ----------------------
 2 files changed, 1 insertion(+), 28 deletions(-)
---
diff --git a/tests/lib/telepathy/contactlist/backend.c b/tests/lib/telepathy/contactlist/backend.c
index b7193dc2..df755396 100644
--- a/tests/lib/telepathy/contactlist/backend.c
+++ b/tests/lib/telepathy/contactlist/backend.c
@@ -121,12 +121,7 @@ _log_fatal_handler (const char *domain,
    const char *message,
    gpointer user_data)
 {
-  gboolean suppress = _log_should_suppress (domain, flags, message);
-
-  if (!suppress)
-    g_on_error_stack_trace ("libtool --mode=exec gdb");
-
-  return !suppress;
+  return !_log_should_suppress (domain, flags, message);
 }
 
 void
diff --git a/tests/lib/test-case.vala b/tests/lib/test-case.vala
index c290daab..86510b9b 100644
--- a/tests/lib/test-case.vala
+++ b/tests/lib/test-case.vala
@@ -446,21 +446,9 @@ public abstract class Folks.TestCase : Object
 
       public static void set_up ()
         {
-          GLib.set_printerr_handler (LogAdaptor._printerr_func_stack_trace);
           Log.set_default_handler (LogAdaptor._log_func_stack_trace);
         }
 
-      private static void _printerr_func_stack_trace (string? text)
-        {
-          if (text == null || str_equal (text, ""))
-            return;
-
-          stderr.printf (text);
-
-          /* Print a stack trace since we've hit some major issue */
-          GLib.on_error_stack_trace ("libtool --mode=execute gdb");
-        }
-
       private static void _log_func_stack_trace (string? log_domain,
           LogLevelFlags log_levels,
           string message)
@@ -472,16 +460,6 @@ public abstract class Folks.TestCase : Object
            * being forcibly disposed */
           if (TestCase.in_final_tear_down)
             return;
-
-          /* Print a stack trace for any message at the warning level or above
-           */
-          if ((log_levels &
-              (LogLevelFlags.LEVEL_WARNING | LogLevelFlags.LEVEL_ERROR |
-                  LogLevelFlags.LEVEL_CRITICAL))
-              != 0)
-            {
-              GLib.on_error_stack_trace ("libtool --mode=execute gdb");
-            }
         }
     }
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]