[libdazzle] widgets: do not reset child position on DzlMultiPaned::add



commit 650ea2f352851fda192b5c3497b5ef40e5bca6c1
Author: Christian Hergert <chergert redhat com>
Date:   Thu Apr 18 12:17:13 2019 -0700

    widgets: do not reset child position on DzlMultiPaned::add
    
    If we reset the positions each time a child is added, we don't allow
    GtkBuilder .ui files to be able to set the position child property. That
    is problematic since it requires apps to write code to set the
    drag positions.
    
    It doesn't seem to create much of an issue in practice to drop this.

 src/widgets/dzl-multi-paned.c | 2 --
 1 file changed, 2 deletions(-)
---
diff --git a/src/widgets/dzl-multi-paned.c b/src/widgets/dzl-multi-paned.c
index ad1683d..59d4250 100644
--- a/src/widgets/dzl-multi-paned.c
+++ b/src/widgets/dzl-multi-paned.c
@@ -561,8 +561,6 @@ dzl_multi_paned_add (GtkContainer *container,
 
   g_array_append_val (priv->children, child);
 
-  dzl_multi_paned_reset_positions (self);
-
   gtk_gesture_set_state (GTK_GESTURE (priv->gesture), GTK_EVENT_SEQUENCE_DENIED);
 
   gtk_widget_queue_resize (GTK_WIDGET (self));


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]