[gnome-initial-setup/wjt/secret-warnings] ci: make warnings fatal, except deprecated-declarations

[Will Thompson <wjt src gnome org>]

commit 969b4cf3d766b531db937dc954cf7451c69a61c2
Author: Will Thompson <wjt endlessm com>
Date:   Thu Apr 18 09:27:35 2019 +0100

    ci: make warnings fatal, except deprecated-declarations
    
    The double-free fixed in the previous commit was caught by a compiler
    warning (because one variable being free'd was declared to be const).
    Aside from use of deprecated functions, there are no other warnings in
    the codebase. Make all other warnings fatal in CI.

 .gitlab-ci.yml | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
---
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index c4b124a..42897e2 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -9,7 +9,12 @@ before_script:
 .job_template: &job_definition
   stage: build
   script:
-    - meson -Dregion-page=${REGION_PAGE} --auto-features ${AUTO_FEATURES} _build .
+    # In general, we would like warnings to be fatal. However, code copied from
+    # gnome-control-center uses many deprecated functions. Until we have a good
+    # answer to sharing that code (#68), make those warnings non-fatal.
+    - meson -Dregion-page=${REGION_PAGE} --auto-features ${AUTO_FEATURES}
+      -Dwerror=true -Dc_args=-Wno-error=deprecated-declarations
+      _build .
     - cd _build
     - ninja
     # Check that strings can be extracted