[gnome-music/wip/jfelder/mpris-fix-activateplaylist: 8/9] playlistview: Do not manually emit row-activated signal
- From: Jean Felder <jfelder src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-music/wip/jfelder/mpris-fix-activateplaylist: 8/9] playlistview: Do not manually emit row-activated signal
- Date: Mon, 15 Apr 2019 16:10:50 +0000 (UTC)
commit a427b34816fda1d5a5843a6156c8e12ea5486490
Author: Jean Felder <jfelder src gnome org>
Date: Mon Apr 15 15:45:40 2019 +0200
playlistview: Do not manually emit row-activated signal
"row-activated" of a GtkListBox is not an action signal, it should not
be emitted manually.
Use "activate" signal from the row instead.
gnomemusic/views/playlistview.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/gnomemusic/views/playlistview.py b/gnomemusic/views/playlistview.py
index f77722fc..e16546d0 100644
--- a/gnomemusic/views/playlistview.py
+++ b/gnomemusic/views/playlistview.py
@@ -315,7 +315,7 @@ class PlaylistView(BaseView):
if len(self._sidebar) == 1:
self._sidebar.select_row(row)
- self._sidebar.emit('row-activated', row)
+ row.emit('activate')
@log
def _on_song_validated(self, player, index, status):
@@ -497,7 +497,7 @@ class PlaylistView(BaseView):
handler = self.connect('playlist-songs-loaded',
songs_loaded_callback)
- self._sidebar.emit('row-activated', row)
+ row.emit('activate')
return
@@ -679,7 +679,7 @@ class PlaylistView(BaseView):
if row_next:
self._sidebar.select_row(row_next)
- self._sidebar.emit('row-activated', row_next)
+ row_next.emit('activate')
self._create_notification(
PlaylistNotification.Type.PLAYLIST, playlist_id)
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]