[glib/glib-2-60: 3/4] tests: Only run --external-data test on GNU ld/objcopy



commit 30b153923fc7028ab02897a87a9d4ace0bed01ed
Author: Philip Withnall <withnall endlessm com>
Date:   Fri Apr 12 14:13:58 2019 +0100

    tests: Only run --external-data test on GNU ld/objcopy
    
    Other GCC-like implementations of ld/objcopy (like LLVM) don’t yet
    support the right command line arguments, so can’t compile the test.
    
    Signed-off-by: Philip Withnall <withnall endlessm com>
    
    https://gitlab.gnome.org/GNOME/glib/issues/1709

 gio/tests/meson.build | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
---
diff --git a/gio/tests/meson.build b/gio/tests/meson.build
index 61320cb47..65f43e267 100644
--- a/gio/tests/meson.build
+++ b/gio/tests/meson.build
@@ -560,9 +560,12 @@ if not meson.is_cross_build() or meson.has_exe_wrapper()
     digit_test_resources_h,
   ]
 
-  # Create object file containing resource data
-  # for testing the external data option
-  if build_machine.system() == 'linux'
+  # Create object file containing resource data for testing the --external-data
+  # option. Currently only GNU ld and GNU objcopy support the right options.
+  # Support for --add-symbol was added to LLVM objcopy in 2019
+  # (https://reviews.llvm.org/D58234). FIXME: This test could be enabled for
+  # LLVM once that support is in a stable release.
+  if build_machine.system() == 'linux' and cc.get_id() == 'gcc'
     test_gresource_binary = custom_target('test5.gresource',
       input : 'test5.gresource.xml',
       output : 'test5.gresource',


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]