[gjs: 22/26] context: Change EnvironmentPreparer to protected inheritance



commit 821557e7f18a458ff41c0bbadeac0019d9dcaf65
Author: Philip Chimento <philip chimento gmail com>
Date:   Sun Mar 24 20:09:07 2019 -0700

    context: Change EnvironmentPreparer to protected inheritance
    
    This avoids a compiler warning due to js::ScriptEnvironmentPreparer
    having virtual methods but not a virtual destructor. Since we are not
    intending to use this class polymorphically, the virtual destructor
    should not matter.

 gjs/context-private.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/gjs/context-private.h b/gjs/context-private.h
index 24ec33e5..604f640b 100644
--- a/gjs/context-private.h
+++ b/gjs/context-private.h
@@ -85,7 +85,7 @@ class GjsContextPrivate {
 
     /* Environment preparer needed for debugger, taken from SpiderMonkey's
      * JS shell */
-    struct EnvironmentPreparer final : public js::ScriptEnvironmentPreparer {
+    struct EnvironmentPreparer final : protected js::ScriptEnvironmentPreparer {
         JSContext* m_cx;
 
         explicit EnvironmentPreparer(JSContext* cx) : m_cx(cx) {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]