[gnome-shell-extensions/wip/fmuellner/fix-windows-navigator: 3/3] cleanup: Use an extension object instead of globals
- From: Florian Müllner <fmuellner src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell-extensions/wip/fmuellner/fix-windows-navigator: 3/3] cleanup: Use an extension object instead of globals
- Date: Mon, 8 Apr 2019 06:00:49 +0000 (UTC)
commit 3671d5a299ca8b42538ce9b09d857b950aa29ea7
Author: Florian Müllner <fmuellner gnome org>
Date: Wed Mar 20 08:59:09 2019 +0000
cleanup: Use an extension object instead of globals
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/issues/143
extensions/windowsNavigator/extension.js | 34 ++++++++++++++++++--------------
1 file changed, 19 insertions(+), 15 deletions(-)
---
diff --git a/extensions/windowsNavigator/extension.js b/extensions/windowsNavigator/extension.js
index 831258a..05d2965 100644
--- a/extensions/windowsNavigator/extension.js
+++ b/extensions/windowsNavigator/extension.js
@@ -1,5 +1,5 @@
/* -*- mode: js2; js2-basic-offset: 4; indent-tabs-mode: nil -*- */
-/* exported init enable disable */
+/* exported init */
const { Clutter, St } = imports.gi;
const Main = imports.ui.main;
@@ -239,22 +239,26 @@ var MyWorkspacesView = class extends WorkspacesView.WorkspacesView {
}
};
-let origWindowOverlay, origWorkspace, origWorkspacesView;
+class Extension {
+ constructor() {
+ this._origWindowOverlay = Workspace.WindowOverlay;
+ this._origWorkspace = Workspace.Workspace;
+ this._origWorkspacesView = WorkspacesView.WorkspacesView;
+ }
-function init() {
- origWindowOverlay = Workspace.WindowOverlay;
- origWorkspace = Workspace.Workspace;
- origWorkspacesView = WorkspacesView.WorkspacesView;
-}
+ enable() {
+ Workspace.WindowOverlay = MyWindowOverlay;
+ Workspace.Workspace = MyWorkspace;
+ WorkspacesView.WorkspacesView = MyWorkspacesView;
+ }
-function enable() {
- Workspace.WindowOverlay = MyWindowOverlay;
- Workspace.Workspace = MyWorkspace;
- WorkspacesView.WorkspacesView = MyWorkspacesView;
+ disable() {
+ Workspace.WindowOverlay = this._origWindowOverlay;
+ Workspace.Workspace = this._origWorkspace;
+ WorkspacesView.WorkspacesView = this._origWorkspacesView;
+ }
}
-function disable() {
- Workspace.WindowOverlay = origWindowOverlay;
- Workspace.Workspace = origWorkspace;
- WorkspacesView.WorkspacesView = origWorkspacesView;
+function init() {
+ return new Extension();
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]