[libgda] Fixed warnings on freeing slist

[Daniel Espinosa Ortiz <despinosa src gnome org>]

commit 1d882ab018212e42d386045091a19acf909bd6e7
Author: Daniel Espinosa <esodan gmail com>
Date:   Wed Apr 3 18:56:31 2019 -0600

    Fixed warnings on freeing slist

 libgda/sql-parser/gda-statement-struct-insert.c        | 3 +--
 libgda/sql-parser/gda-statement-struct-parts.c         | 3 +--
 providers/skel-implementation/capi/gda-capi-provider.c | 3 +--
 tests/value-holders/check_holder.c                     | 3 +--
 4 files changed, 4 insertions(+), 8 deletions(-)
---
diff --git a/libgda/sql-parser/gda-statement-struct-insert.c b/libgda/sql-parser/gda-statement-struct-insert.c
index 745b2b642..9a6ef9244 100644
--- a/libgda/sql-parser/gda-statement-struct-insert.c
+++ b/libgda/sql-parser/gda-statement-struct-insert.c
@@ -80,8 +80,7 @@ gda_sql_statement_insert_free (gpointer stmt)
        }
        g_slist_free (insert->values_list);
 
-       g_slist_foreach (insert->fields_list, (GFunc) gda_sql_field_free, NULL);
-       g_slist_free (insert->fields_list);
+       g_slist_free_full (insert->fields_list, (GDestroyNotify) gda_sql_field_free);
        if (insert->select) {
                if (GDA_SQL_ANY_PART (insert->select)->type == GDA_SQL_ANY_STMT_SELECT)
                        _gda_sql_statement_select_free (insert->select);
diff --git a/libgda/sql-parser/gda-statement-struct-parts.c b/libgda/sql-parser/gda-statement-struct-parts.c
index f05b5863f..2bbe452ae 100644
--- a/libgda/sql-parser/gda-statement-struct-parts.c
+++ b/libgda/sql-parser/gda-statement-struct-parts.c
@@ -469,8 +469,7 @@ gda_sql_function_free (GdaSqlFunction *function)
 
        g_free (function->function_name);
        if (function->args_list) {
-               g_slist_foreach (function->args_list, (GFunc) gda_sql_expr_free, NULL);
-               g_slist_free (function->args_list);
+               g_slist_free_full (function->args_list, (GDestroyNotify) gda_sql_expr_free);
        }
        g_free (function);
 }
diff --git a/providers/skel-implementation/capi/gda-capi-provider.c 
b/providers/skel-implementation/capi/gda-capi-provider.c
index c69f1e704..078e0a6cf 100644
--- a/providers/skel-implementation/capi/gda-capi-provider.c
+++ b/providers/skel-implementation/capi/gda-capi-provider.c
@@ -1061,8 +1061,7 @@ gda_capi_provider_statement_prepare (GdaServerProvider *provider, GdaConnection
                         else {
                                 g_set_error (error, GDA_SERVER_PROVIDER_ERROR, 
GDA_SERVER_PROVIDER_PREPARE_STMT_ERROR,
                                              "%s", _("Unnamed parameter is not allowed in prepared 
statements"));
-                                g_slist_foreach (param_ids, (GFunc) g_free, NULL);
-                                g_slist_free (param_ids);
+                                g_slist_free_full (param_ids, (GDestroyNotify) g_free);
                                 goto out;
                         }
                 }
diff --git a/tests/value-holders/check_holder.c b/tests/value-holders/check_holder.c
index 32cdfaf2c..67a0cbf76 100644
--- a/tests/value-holders/check_holder.c
+++ b/tests/value-holders/check_holder.c
@@ -1100,8 +1100,7 @@ emitted_signal_add (EmittedSignal *es)
 static void
 emitted_signals_reset (void)
 {
-       g_slist_foreach (signals_list, (GFunc) g_free, NULL);
-       g_slist_free (signals_list);
+       g_slist_free_full (signals_list, (GDestroyNotify) g_free);
        signals_list = NULL;
 }