[gtk/async-api: 2/2] gdk: Change some async api
- From: Matthias Clasen <matthiasc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtk/async-api: 2/2] gdk: Change some async api
- Date: Tue, 2 Apr 2019 11:40:13 +0000 (UTC)
commit 37bdd1d4a4dcbdbf0ac7579960306b111c03f01f
Author: Matthias Clasen <mclasen redhat com>
Date: Tue Apr 2 11:38:52 2019 +0000
gdk: Change some async api
The pattern we generally follow is to put the
async result right after the source object, in
finish functions. Do this for gdk_drop_read_finish.
gdk/gdkdrop.c | 12 ++++++------
gdk/gdkdrop.h | 2 +-
gdk/gdkdropprivate.h | 2 +-
gdk/wayland/gdkdrop-wayland.c | 2 +-
gdk/win32/gdkdrop-win32.c | 2 +-
gdk/x11/gdkdrop-x11.c | 2 +-
6 files changed, 11 insertions(+), 11 deletions(-)
---
diff --git a/gdk/gdkdrop.c b/gdk/gdkdrop.c
index 643a74d790..ea85862a4c 100644
--- a/gdk/gdkdrop.c
+++ b/gdk/gdkdrop.c
@@ -149,8 +149,8 @@ gdk_drop_read_local_async (GdkDrop *self,
static GInputStream *
gdk_drop_read_local_finish (GdkDrop *self,
- const char **out_mime_type,
GAsyncResult *result,
+ const char **out_mime_type,
GError **error)
{
g_return_val_if_fail (g_task_is_valid (result, self), NULL);
@@ -622,8 +622,8 @@ gdk_drop_read_async (GdkDrop *self,
/**
* gdk_drop_read_finish:
* @self: a #GdkDrop
- * @out_mime_type: (out) (type utf8): return location for the used mime type
* @result: a #GAsyncResult
+ * @out_mime_type: (out) (type utf8): return location for the used mime type
* @error: (allow-none): location to store error information on failure, or %NULL
*
* Finishes an async drop read operation, see gdk_drop_read_async().
@@ -632,8 +632,8 @@ gdk_drop_read_async (GdkDrop *self,
*/
GInputStream *
gdk_drop_read_finish (GdkDrop *self,
- const char **out_mime_type,
GAsyncResult *result,
+ const char **out_mime_type,
GError **error)
{
g_return_val_if_fail (GDK_IS_DROP (self), NULL);
@@ -641,11 +641,11 @@ gdk_drop_read_finish (GdkDrop *self,
if (g_async_result_is_tagged (result, gdk_drop_read_local_async))
{
- return gdk_drop_read_local_finish (self, out_mime_type, result, error);
+ return gdk_drop_read_local_finish (self, result, out_mime_type, error);
}
else
{
- return GDK_DROP_GET_CLASS (self)->read_finish (self, out_mime_type, result, error);
+ return GDK_DROP_GET_CLASS (self)->read_finish (self, result, out_mime_type, error);
}
}
@@ -678,7 +678,7 @@ gdk_drop_read_value_got_stream (GObject *source,
GTask *task = data;
const char *mime_type;
- stream = gdk_drop_read_finish (GDK_DROP (source), &mime_type, result, &error);
+ stream = gdk_drop_read_finish (GDK_DROP (source), result, &mime_type, &error);
if (stream == NULL)
{
g_task_return_error (task, error);
diff --git a/gdk/gdkdrop.h b/gdk/gdkdrop.h
index e2f26e1822..857d44082f 100644
--- a/gdk/gdkdrop.h
+++ b/gdk/gdkdrop.h
@@ -68,8 +68,8 @@ void gdk_drop_read_async (GdkDrop
gpointer user_data);
GDK_AVAILABLE_IN_ALL
GInputStream * gdk_drop_read_finish (GdkDrop *self,
- const char **out_mime_type,
GAsyncResult *result,
+ const char **out_mime_type,
GError **error);
GDK_AVAILABLE_IN_ALL
void gdk_drop_read_value_async (GdkDrop *self,
diff --git a/gdk/gdkdropprivate.h b/gdk/gdkdropprivate.h
index 86a1fdbf8a..b20eee2ae7 100644
--- a/gdk/gdkdropprivate.h
+++ b/gdk/gdkdropprivate.h
@@ -51,8 +51,8 @@ struct _GdkDropClass {
GAsyncReadyCallback callback,
gpointer user_data);
GInputStream * (* read_finish) (GdkDrop *self,
- const char **out_mime_type,
GAsyncResult *result,
+ const char **out_mime_type,
GError **error);
};
diff --git a/gdk/wayland/gdkdrop-wayland.c b/gdk/wayland/gdkdrop-wayland.c
index a0a02a33b4..3e0a25deaa 100644
--- a/gdk/wayland/gdkdrop-wayland.c
+++ b/gdk/wayland/gdkdrop-wayland.c
@@ -224,8 +224,8 @@ gdk_wayland_drop_read_async (GdkDrop *drop,
static GInputStream *
gdk_wayland_drop_read_finish (GdkDrop *drop,
- const char **out_mime_type,
GAsyncResult *result,
+ const char **out_mime_type,
GError **error)
{
GTask *task;
diff --git a/gdk/win32/gdkdrop-win32.c b/gdk/win32/gdkdrop-win32.c
index e457ce12a4..44dab15c19 100644
--- a/gdk/win32/gdkdrop-win32.c
+++ b/gdk/win32/gdkdrop-win32.c
@@ -1382,8 +1382,8 @@ gdk_win32_drop_read_async (GdkDrop *drop,
static GInputStream *
gdk_win32_drop_read_finish (GdkDrop *drop,
- const char **out_mime_type,
GAsyncResult *result,
+ const char **out_mime_type,
GError **error)
{
GTask *task;
diff --git a/gdk/x11/gdkdrop-x11.c b/gdk/x11/gdkdrop-x11.c
index 050695bf9c..bb5fbef238 100644
--- a/gdk/x11/gdkdrop-x11.c
+++ b/gdk/x11/gdkdrop-x11.c
@@ -211,8 +211,8 @@ gdk_x11_drop_read_async (GdkDrop *drop,
static GInputStream *
gdk_x11_drop_read_finish (GdkDrop *drop,
- const char **out_mime_type,
GAsyncResult *result,
+ const char **out_mime_type,
GError **error)
{
GTask *task;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]