[gnome-software] Remove redundant GtkBox::fill properties



commit 2dc35f66e248c3904ffeba30f4da6b0ee471cee8
Author: Robert Ancell <robert ancell canonical com>
Date:   Wed Sep 26 16:23:13 2018 +1200

    Remove redundant GtkBox::fill properties
    
    GtkBox::fill is removed in GTK+ 4.

 src/gnome-software.ui          |  3 ---
 src/gs-app-addon-row.ui        |  7 -------
 src/gs-app-row.ui              | 28 ----------------------------
 src/gs-auth-dialog.ui          |  1 -
 src/gs-category-page.ui        | 38 --------------------------------------
 src/gs-details-page.ui         | 38 --------------------------------------
 src/gs-editor.ui               |  2 --
 src/gs-info-bar.ui             |  1 -
 src/gs-overview-page.ui        |  3 ---
 src/gs-repo-row.ui             | 13 -------------
 src/gs-review-dialog.ui        |  1 -
 src/gs-review-row.ui           |  5 -----
 src/gs-third-party-repo-row.ui | 12 ------------
 src/gs-updates-page.ui         |  6 ------
 src/gs-upgrade-banner.ui       | 12 ------------
 15 files changed, 170 deletions(-)
---
diff --git a/src/gnome-software.ui b/src/gnome-software.ui
index 79787692..a5e286c4 100644
--- a/src/gnome-software.ui
+++ b/src/gnome-software.ui
@@ -478,9 +478,6 @@
                           </object>
                         </child>
                       </object>
-                      <packing>
-                        <property name="fill">False</property>
-                      </packing>
                     </child>
                     <child>
                       <object class="GtkButton" id="button_events_dismiss">
diff --git a/src/gs-app-addon-row.ui b/src/gs-app-addon-row.ui
index 8f643870..ac81d93a 100644
--- a/src/gs-app-addon-row.ui
+++ b/src/gs-app-addon-row.ui
@@ -16,9 +16,6 @@
             <property name="visible">True</property>
             <property name="valign">center</property>
           </object>
-          <packing>
-            <property name="fill">False</property>
-          </packing>
         </child>
         <child>
           <object class="GtkBox" id="name_box">
@@ -35,9 +32,6 @@
                 <property name="xalign">0.0</property>
                 <property name="yalign">0.5</property>
               </object>
-              <packing>
-                <property name="fill">False</property>
-              </packing>
             </child>
             <child>
               <object class="GtkLabel" id="description_label">
@@ -62,7 +56,6 @@
           </object>
           <packing>
             <property name="pack_type">end</property>
-            <property name="fill">False</property>
           </packing>
         </child>
       </object>
diff --git a/src/gs-app-row.ui b/src/gs-app-row.ui
index dcba79b0..40cf62d5 100644
--- a/src/gs-app-row.ui
+++ b/src/gs-app-row.ui
@@ -17,9 +17,6 @@
             <property name="margin-start">12</property>
             <property name="valign">center</property>
           </object>
-          <packing>
-            <property name="fill">False</property>
-          </packing>
         </child>
         <child>
           <object class="GtkImage" id="image">
@@ -28,9 +25,6 @@
             <property name="margin_start">24</property>
             <property name="valign">center</property>
           </object>
-          <packing>
-            <property name="fill">False</property>
-          </packing>
         </child>
         <child>
           <object class="GtkBox" id="name_box">
@@ -61,18 +55,12 @@
                 <property name="yalign">0.5</property>
                 <property name="ellipsize">end</property>
               </object>
-              <packing>
-                <property name="fill">False</property>
-              </packing>
             </child>
             <child>
               <object class="GsStarWidget" id="star">
                 <property name="visible">False</property>
                 <property name="halign">start</property>
               </object>
-              <packing>
-                <property name="fill">False</property>
-              </packing>
             </child>
             <child>
               <object class="GtkLabel" id="folder_label">
@@ -86,9 +74,6 @@
                   <class name="folder-label"/>
                 </style>
               </object>
-              <packing>
-                <property name="fill">False</property>
-              </packing>
             </child>
           </object>
         </child>
@@ -183,9 +168,6 @@
                              <class name="app-row-installed-icon"/>
                            </style>
                          </object>
-                         <packing>
-                            <property name="fill">False</property>
-                         </packing>
                        </child>
                        <child>
                          <object class="GtkLabel" id="installed-label">
@@ -195,9 +177,6 @@
                              <class name="app-row-installed-label"/>
                            </style>
                          </object>
-                         <packing>
-                            <property name="fill">False</property>
-                         </packing>
                        </child>
                      </object>
                    </child>
@@ -231,7 +210,6 @@
                  </object>
                  <packing>
                     <property name="pack_type">end</property>
-                    <property name="fill">False</property>
                  </packing>
                </child>
                <child>
@@ -242,7 +220,6 @@
                  </object>
                  <packing>
                     <property name="pack_type">end</property>
-                    <property name="fill">False</property>
                  </packing>
                </child>
                <child>
@@ -253,14 +230,9 @@
                  </object>
                  <packing>
                     <property name="pack_type">end</property>
-                    <property name="fill">False</property>
                  </packing>
                </child>
               </object>
-              <packing>
-               <property name="pack_type">start</property>
-               <property name="fill">False</property>
-              </packing>
             </child>
            <child>
              <object class="GtkLabel" id="label_app_size">
diff --git a/src/gs-auth-dialog.ui b/src/gs-auth-dialog.ui
index 70f69b2d..fe04619d 100644
--- a/src/gs-auth-dialog.ui
+++ b/src/gs-auth-dialog.ui
@@ -23,7 +23,6 @@
             </child>
           </object>
           <packing>
-            <property name="fill">False</property>
             <property name="position">0</property>
           </packing>
         </child>
diff --git a/src/gs-category-page.ui b/src/gs-category-page.ui
index 08ba5923..ad1a7c3b 100644
--- a/src/gs-category-page.ui
+++ b/src/gs-category-page.ui
@@ -73,10 +73,6 @@
                                   <class name="category_page_header_filter_box"/>
                                 </style>
                               </object>
-                              <packing>
-                                <property name="fill">False</property>
-                                <property name="pack-type">start</property>
-                              </packing>
                             </child>
                             <child>
                               <object class="GtkLabel" id="featured_heading">
@@ -93,10 +89,6 @@
                                   <class name="index-title-alignment-software"/>
                                 </style>
                               </object>
-                              <packing>
-                                <property name="fill">False</property>
-                                <property name="pack-type">start</property>
-                              </packing>
                             </child>
                             <child>
                               <object class="GtkGrid" id="featured_grid">
@@ -106,10 +98,6 @@
                                 <property name="margin_start">24</property>
                                 <property name="margin_end">24</property>
                               </object>
-                              <packing>
-                                <property name="fill">False</property>
-                                <property name="pack-type">start</property>
-                              </packing>
                             </child>
                             <child>
                               <object class="GtkInfoBar" id="infobar_category_shell_extensions">
@@ -143,7 +131,6 @@
                                     </child>
                                   </object>
                                   <packing>
-                                    <property name="fill">False</property>
                                     <property name="position">0</property>
                                   </packing>
                                 </child>
@@ -167,7 +154,6 @@
                                     </child>
                                   </object>
                                   <packing>
-                                    <property name="fill">False</property>
                                     <property name="position">0</property>
                                   </packing>
                                 </child>
@@ -193,10 +179,6 @@
                                       <relation target="subcats_filter_button" type="label-for"/>
                                     </accessibility>
                                   </object>
-                                  <packing>
-                                    <property name="fill">False</property>
-                                    <property name="pack-type">start</property>
-                                  </packing>
                                 </child>
                                 <child>
                                   <object class="GtkMenuButton" id="subcats_filter_button">
@@ -231,9 +213,6 @@
                                             <property name="can_focus">False</property>
                                             <property name="arrow_type">down</property>
                                           </object>
-                                          <packing>
-                                            <property name="fill">False</property>
-                                          </packing>
                                         </child>
                                       </object>
                                     </child>
@@ -241,10 +220,6 @@
                                       <class name="text-button"/>
                                     </style>
                                   </object>
-                                  <packing>
-                                    <property name="fill">False</property>
-                                    <property name="pack-type">start</property>
-                                  </packing>
                                 </child>
                                 <child>
                                   <object class="GtkLabel" id="subcats_sort_label">
@@ -256,10 +231,6 @@
                                       <relation target="subcats_sort_button" type="label-for"/>
                                     </accessibility>
                                   </object>
-                                  <packing>
-                                    <property name="fill">False</property>
-                                    <property name="pack-type">start</property>
-                                  </packing>
                                 </child>
                                 <child>
                                   <object class="GtkMenuButton" id="subcats_sort_button">
@@ -294,7 +265,6 @@
                                             <property name="arrow_type">down</property>
                                           </object>
                                           <packing>
-                                            <property name="fill">False</property>
                                             <property name="pack-type">end</property>
                                           </packing>
                                         </child>
@@ -304,16 +274,8 @@
                                       <class name="text-button"/>
                                     </style>
                                   </object>
-                                  <packing>
-                                    <property name="fill">False</property>
-                                    <property name="pack-type">start</property>
-                                  </packing>
                                 </child>
                               </object>
-                              <packing>
-                                <property name="fill">False</property>
-                                <property name="pack-type">start</property>
-                              </packing>
                             </child>
 
                             <child>
diff --git a/src/gs-details-page.ui b/src/gs-details-page.ui
index 9b9f5dd3..14194d46 100644
--- a/src/gs-details-page.ui
+++ b/src/gs-details-page.ui
@@ -80,7 +80,6 @@
                                 <property name="pixel_size">96</property>
                               </object>
                               <packing>
-                                <property name="fill">False</property>
                                 <property name="position">0</property>
                               </packing>
                             </child>
@@ -150,7 +149,6 @@
                                     <property name="valign">center</property>
                                   </object>
                                   <packing>
-                                    <property name="fill">False</property>
                                     <property name="position">0</property>
                                   </packing>
                                 </child>
@@ -165,20 +163,17 @@
                                     </style>
                                   </object>
                                   <packing>
-                                    <property name="fill">False</property>
                                     <property name="position">1</property>
                                   </packing>
                                 </child>
                               </object>
                               <packing>
-                                <property name="fill">False</property>
                                 <property name="position">2</property>
                               </packing>
                             </child>
 
                           </object>
                           <packing>
-                            <property name="fill">False</property>
                             <property name="position">0</property>
                           </packing>
                         </child>
@@ -203,7 +198,6 @@
                                 </style>
                               </object>
                               <packing>
-                                <property name="fill">False</property>
                                 <property name="position">0</property>
                               </packing>
                             </child>
@@ -218,7 +212,6 @@
                                 </style>
                               </object>
                               <packing>
-                                <property name="fill">False</property>
                                 <property name="position">1</property>
                               </packing>
                             </child>
@@ -233,7 +226,6 @@
                                 <property name="valign">start</property>
                               </object>
                               <packing>
-                                <property name="fill">False</property>
                                 <property name="position">2</property>
                               </packing>
                             </child>
@@ -242,7 +234,6 @@
                                 <property name="can_focus">False</property>
                               </object>
                               <packing>
-                                <property name="fill">False</property>
                                 <property name="position">3</property>
                               </packing>
                             </child>
@@ -278,9 +269,6 @@
                                         <property name="can_focus">False</property>
                                         <property name="label">Downloading</property>
                                       </object>
-                                      <packing>
-                                        <property name="fill">False</property>
-                                      </packing>
                                     </child>
                                     <child>
                                       <object class="GtkLabel" id="label_progress_percentage">
@@ -288,13 +276,9 @@
                                         <property name="can_focus">False</property>
                                         <property name="label">50%</property>
                                       </object>
-                                      <packing>
-                                        <property name="fill">False</property>
-                                      </packing>
                                     </child>
                                   </object>
                                   <packing>
-                                    <property name="fill">False</property>
                                     <property name="position">0</property>
                                   </packing>
                                 </child>
@@ -312,7 +296,6 @@
                                 <property name="receives_default">True</property>
                               </object>
                               <packing>
-                                <property name="fill">False</property>
                                 <property name="position">5</property>
                               </packing>
                             </child>
@@ -325,7 +308,6 @@
                                 <property name="label" translatable="yes" comments="Translators: A label for 
a button to add a shortcut to the selected application.">_Add shortcut</property>
                               </object>
                               <packing>
-                                <property name="fill">False</property>
                                 <property name="position">6</property>
                                 <property name="pack-type">end</property>
                               </packing>
@@ -339,7 +321,6 @@
                                 <property name="label" translatable="yes" comments="Translators: A label for 
a button to remove a shortcut to the selected application.">Re_move shortcut</property>
                               </object>
                               <packing>
-                                <property name="fill">False</property>
                                 <property name="position">7</property>
                                 <property name="pack-type">end</property>
                               </packing>
@@ -450,7 +431,6 @@
                             </child>
                           </object>
                           <packing>
-                            <property name="fill">False</property>
                             <property name="position">4</property>
                           </packing>
                         </child>
@@ -463,7 +443,6 @@
                             <property name="body" translatable="yes">This application includes a software 
repository which provides updates, as well as access to other software.</property>
                           </object>
                           <packing>
-                            <property name="fill">False</property>
                             <property name="position">6</property>
                           </packing>
                         </child>
@@ -476,7 +455,6 @@
                             <property name="body" translatable="yes">This application does not include a 
software repository. It will not be updated with new versions.</property>
                           </object>
                           <packing>
-                            <property name="fill">False</property>
                             <property name="position">7</property>
                           </packing>
                         </child>
@@ -489,7 +467,6 @@
                             <property name="title" translatable="yes">This software is already provided by 
your distribution and should not be replaced.</property>
                           </object>
                           <packing>
-                            <property name="fill">False</property>
                             <property name="position">8</property>
                           </packing>
                         </child>
@@ -503,7 +480,6 @@
                             <property name="warning" translatable="yes">Only use software repositories that 
you trust.</property>
                           </object>
                           <packing>
-                            <property name="fill">False</property>
                             <property name="position">9</property>
                           </packing>
                         </child>
@@ -523,7 +499,6 @@
                                 <property name="use_underline">True</property>
                               </object>
                               <packing>
-                                <property name="fill">False</property>
                                 <property name="position">0</property>
                               </packing>
                             </child>
@@ -537,13 +512,11 @@
                                 <property name="use_underline">True</property>
                               </object>
                               <packing>
-                                <property name="fill">False</property>
                                 <property name="position">1</property>
                               </packing>
                             </child>
                           </object>
                           <packing>
-                            <property name="fill">False</property>
                             <property name="position">10</property>
                           </packing>
                         </child>
@@ -1058,7 +1031,6 @@
                                         </style>
                                       </object>
                                       <packing>
-                                        <property name="fill">False</property>
                                         <property name="position">0</property>
                                       </packing>
                                     </child>
@@ -1074,7 +1046,6 @@
                                         </style>
                                       </object>
                                       <packing>
-                                        <property name="fill">False</property>
                                         <property name="position">1</property>
                                       </packing>
                                     </child>
@@ -1090,7 +1061,6 @@
                                         </style>
                                       </object>
                                       <packing>
-                                        <property name="fill">False</property>
                                         <property name="position">2</property>
                                       </packing>
                                     </child>
@@ -1351,7 +1321,6 @@
             </attributes>
           </object>
           <packing>
-            <property name="fill">False</property>
             <property name="position">0</property>
           </packing>
         </child>
@@ -1366,7 +1335,6 @@
             <property name="xalign">0</property>
           </object>
           <packing>
-            <property name="fill">False</property>
             <property name="position">1</property>
           </packing>
         </child>
@@ -1380,7 +1348,6 @@
             <property name="xalign">0</property>
           </object>
           <packing>
-            <property name="fill">False</property>
             <property name="position">2</property>
           </packing>
         </child>
@@ -1422,7 +1389,6 @@
             </attributes>
           </object>
           <packing>
-            <property name="fill">False</property>
             <property name="position">0</property>
           </packing>
         </child>
@@ -1437,7 +1403,6 @@
             <property name="xalign">0</property>
           </object>
           <packing>
-            <property name="fill">False</property>
             <property name="position">1</property>
           </packing>
         </child>
@@ -1452,7 +1417,6 @@
             <property name="xalign">0</property>
           </object>
           <packing>
-            <property name="fill">False</property>
             <property name="position">2</property>
           </packing>
         </child>
@@ -1481,7 +1445,6 @@
             </attributes>
           </object>
           <packing>
-            <property name="fill">False</property>
             <property name="position">0</property>
           </packing>
         </child>
@@ -1496,7 +1459,6 @@
             <property name="xalign">0</property>
           </object>
           <packing>
-            <property name="fill">False</property>
             <property name="position">1</property>
           </packing>
         </child>
diff --git a/src/gs-editor.ui b/src/gs-editor.ui
index 23598667..89e52daa 100644
--- a/src/gs-editor.ui
+++ b/src/gs-editor.ui
@@ -141,7 +141,6 @@
                                 </child>
                               </object>
                               <packing>
-                                <property name="fill">False</property>
                                 <property name="pack_type">end</property>
                                 <property name="position">0</property>
                               </packing>
@@ -437,7 +436,6 @@
                     </child>
                   </object>
                   <packing>
-                    <property name="fill">False</property>
                     <property name="position">1</property>
                   </packing>
                 </child>
diff --git a/src/gs-info-bar.ui b/src/gs-info-bar.ui
index 8b3dc6f3..160d8176 100644
--- a/src/gs-info-bar.ui
+++ b/src/gs-info-bar.ui
@@ -45,7 +45,6 @@
         </child>
       </object>
       <packing>
-        <property name="fill">False</property>
         <property name="position">0</property>
       </packing>
     </child>
diff --git a/src/gs-overview-page.ui b/src/gs-overview-page.ui
index ad377516..d07d8ebd 100644
--- a/src/gs-overview-page.ui
+++ b/src/gs-overview-page.ui
@@ -30,7 +30,6 @@
                     <child/>
                   </object>
                   <packing>
-                    <property name="fill">False</property>
                     <property name="position">0</property>
                   </packing>
                 </child>
@@ -65,13 +64,11 @@
                         <property name="xalign">0</property>
                       </object>
                       <packing>
-                        <property name="fill">False</property>
                         <property name="position">1</property>
                       </packing>
                     </child>
                   </object>
                   <packing>
-                    <property name="fill">False</property>
                     <property name="position">0</property>
                   </packing>
                 </child>
diff --git a/src/gs-repo-row.ui b/src/gs-repo-row.ui
index 9a4e5251..c709a023 100644
--- a/src/gs-repo-row.ui
+++ b/src/gs-repo-row.ui
@@ -29,9 +29,6 @@
                     <property name="halign">start</property>
                     <property name="ellipsize">end</property>
                   </object>
-                  <packing>
-                    <property name="fill">False</property>
-                  </packing>
                 </child>
                 <child>
                   <object class="GtkLabel" id="status_label">
@@ -41,14 +38,10 @@
                     </style>
                   </object>
                   <packing>
-                    <property name="fill">False</property>
                     <property name="pack-type">end</property>
                   </packing>
                 </child>
               </object>
-              <packing>
-                <property name="fill">False</property>
-              </packing>
             </child>
             <child>
               <object class="GtkLabel" id="comment_label">
@@ -60,9 +53,6 @@
                   <class name="dim-label"/>
                 </style>
               </object>
-              <packing>
-                <property name="fill">False</property>
-              </packing>
             </child>
             <child>
               <object class="GtkRevealer" id="details_revealer">
@@ -117,9 +107,6 @@
                             <property name="halign">start</property>
                             <property name="valign">start</property>
                           </object>
-                          <packing>
-                            <property name="fill">False</property>
-                          </packing>
                         </child>
                       </object>
                     </child>
diff --git a/src/gs-review-dialog.ui b/src/gs-review-dialog.ui
index c3e0e366..3c5c8cce 100644
--- a/src/gs-review-dialog.ui
+++ b/src/gs-review-dialog.ui
@@ -61,7 +61,6 @@
             <property name="can_focus">False</property>
           </object>
           <packing>
-            <property name="fill">False</property>
             <property name="position">0</property>
           </packing>
         </child>
diff --git a/src/gs-review-row.ui b/src/gs-review-row.ui
index fd450be9..54d4c4c2 100644
--- a/src/gs-review-row.ui
+++ b/src/gs-review-row.ui
@@ -115,7 +115,6 @@
                 </style>
               </object>
               <packing>
-                <property name="fill">False</property>
                 <property name="position">0</property>
               </packing>
             </child>
@@ -137,7 +136,6 @@
                     <property name="relief">none</property>
                   </object>
                   <packing>
-                    <property name="fill">False</property>
                     <property name="position">0</property>
                   </packing>
                 </child>
@@ -150,7 +148,6 @@
                     <property name="relief">none</property>
                   </object>
                   <packing>
-                    <property name="fill">False</property>
                     <property name="position">1</property>
                   </packing>
                 </child>
@@ -163,13 +160,11 @@
                     <property name="relief">none</property>
                   </object>
                   <packing>
-                    <property name="fill">False</property>
                     <property name="position">2</property>
                   </packing>
                 </child>
               </object>
               <packing>
-                <property name="fill">False</property>
                 <property name="position">1</property>
               </packing>
             </child>
diff --git a/src/gs-third-party-repo-row.ui b/src/gs-third-party-repo-row.ui
index 998c5f71..05f8dac9 100644
--- a/src/gs-third-party-repo-row.ui
+++ b/src/gs-third-party-repo-row.ui
@@ -29,14 +29,8 @@
                     <property name="halign">start</property>
                     <property name="ellipsize">end</property>
                   </object>
-                  <packing>
-                    <property name="fill">False</property>
-                  </packing>
                 </child>
               </object>
-              <packing>
-                <property name="fill">False</property>
-              </packing>
             </child>
             <child>
               <object class="GtkLabel" id="comment_label">
@@ -48,9 +42,6 @@
                   <class name="dim-label"/>
                 </style>
               </object>
-              <packing>
-                <property name="fill">False</property>
-              </packing>
             </child>
           </object>
         </child>
@@ -64,9 +55,6 @@
             <property name="halign">end</property>
             <property name="valign">center</property>
           </object>
-          <packing>
-            <property name="fill">False</property>
-          </packing>
         </child>
       </object>
     </child>
diff --git a/src/gs-updates-page.ui b/src/gs-updates-page.ui
index e72b3134..a2545ace 100644
--- a/src/gs-updates-page.ui
+++ b/src/gs-updates-page.ui
@@ -259,9 +259,6 @@
                     <property name="hexpand">False</property>
                     <property name="halign">center</property>
                   </object>
-                  <packing>
-                    <property name="fill">False</property>
-                  </packing>
                 </child>
               </object>
               <packing>
@@ -312,9 +309,6 @@
                     <property name="hexpand">False</property>
                     <property name="halign">center</property>
                   </object>
-                  <packing>
-                    <property name="fill">False</property>
-                  </packing>
                 </child>
               </object>
               <packing>
diff --git a/src/gs-upgrade-banner.ui b/src/gs-upgrade-banner.ui
index b94efd25..ebff9f9c 100644
--- a/src/gs-upgrade-banner.ui
+++ b/src/gs-upgrade-banner.ui
@@ -57,9 +57,6 @@
                 <property name="use_underline">True</property>
                 <property name="relief">normal</property>
               </object>
-              <packing>
-                <property name="fill">False</property>
-              </packing>
             </child>
 
             <child>
@@ -116,9 +113,6 @@
                 <property name="use_underline">True</property>
                 <property name="relief">normal</property>
               </object>
-              <packing>
-                <property name="fill">False</property>
-              </packing>
             </child>
             <child>
               <object class="GtkButton" id="button_upgrades_cancel">
@@ -130,9 +124,6 @@
                 <property name="use_underline">True</property>
                 <property name="relief">normal</property>
               </object>
-              <packing>
-                <property name="fill">False</property>
-              </packing>
             </child>
             <child>
               <object class="GtkButton" id="button_upgrades_install">
@@ -144,9 +135,6 @@
                 <property name="use_underline">True</property>
                 <property name="relief">normal</property>
               </object>
-              <packing>
-                <property name="fill">False</property>
-              </packing>
             </child>
           </object>
         </child>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]