[gegl] buffer: abstract gegl_buffer_set_value out of gegl_buffer_set_color

[Øyvind "pippin" Kolås <ok src gnome org>]

commit b5541fd169b5ead15bbcb088310ea783ed4dc464
Author: Øyvind Kolås <pippin gimp org>
Date:   Thu Sep 27 13:16:59 2018 +0200

    buffer: abstract gegl_buffer_set_value out of  gegl_buffer_set_color
    
    Avoding to use the type GeglColor in GeglBuffer's API will further reduce
    coupling.

 gegl/buffer/gegl-buffer-access.c | 32 ++++++++++++++++++++++----------
 1 file changed, 22 insertions(+), 10 deletions(-)
---
diff --git a/gegl/buffer/gegl-buffer-access.c b/gegl/buffer/gegl-buffer-access.c
index 650e03499..3525a4258 100644
--- a/gegl/buffer/gegl-buffer-access.c
+++ b/gegl/buffer/gegl-buffer-access.c
@@ -2774,19 +2774,17 @@ gegl_buffer_set_pattern (GeglBuffer          *buffer,
   gegl_free (pattern_data);
 }
 
-void
-gegl_buffer_set_color (GeglBuffer          *dst,
+static void
+gegl_buffer_set_value (GeglBuffer          *dst,
                        const GeglRectangle *dst_rect,
-                       GeglColor           *color)
+                       uint8_t             *value,
+                       const Babl          *pixel_format)
 {
   GeglBufferIterator *i;
-  gchar               pixel[128];
   gint                bpp;
 
   g_return_if_fail (GEGL_IS_BUFFER (dst));
-  g_return_if_fail (color);
-
-  gegl_color_get_pixel (color, dst->soft_format, pixel);
+  g_return_if_fail (value);
 
   if (!dst_rect)
     {
@@ -2796,19 +2794,33 @@ gegl_buffer_set_color (GeglBuffer          *dst,
       dst_rect->height == 0)
     return;
 
-  bpp = babl_format_get_bytes_per_pixel (dst->soft_format);
+  bpp = babl_format_get_bytes_per_pixel (pixel_format);
 
   /* FIXME: this can be even further optimized by special casing it so
    * that fully filled tiles are shared.
    */
-  i = gegl_buffer_iterator_new (dst, dst_rect, 0, dst->soft_format,
+  i = gegl_buffer_iterator_new (dst, dst_rect, 0, pixel_format,
                                 GEGL_ACCESS_WRITE, GEGL_ABYSS_NONE, 1);
   while (gegl_buffer_iterator_next (i))
     {
-      gegl_memset_pattern (i->items[0].data, pixel, bpp, i->length);
+      gegl_memset_pattern (i->items[0].data, value, bpp, i->length);
     }
 }
 
+
+void
+gegl_buffer_set_color (GeglBuffer          *dst,
+                       const GeglRectangle *dst_rect,
+                       GeglColor           *color)
+{
+  uint8_t pixel[128];
+  g_return_if_fail (GEGL_IS_BUFFER (dst));
+  g_return_if_fail (color);
+
+  gegl_color_get_pixel (color, dst->soft_format, pixel);
+  gegl_buffer_set_value (dst, dst_rect, &pixel[0], dst->soft_format);
+}
+
 GeglBuffer *
 gegl_buffer_dup (GeglBuffer *buffer)
 {