[gtranslator] Don't compare msgid on selection change



commit 8b5d10c2fb75008d58bc7d7926cf72731315e886
Author: Daniel GarcĂ­a Moreno <danigm wadobo com>
Date:   Tue Sep 25 18:09:23 2018 +0200

    Don't compare msgid on selection change
    
    Comparing the msgid on selection change is causing problems because
    it's possible to have multiple msgs with the same msgid and different
    context.
    
    We could compare also the context, but I think that there's not much
    waste in send the signal and do all the work if it's the same message,
    the check complicate the code and don't give us an appreciable
    performance improvement, so I've removed it.
    
    Fix #19

 src/gtr-message-table.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
---
diff --git a/src/gtr-message-table.c b/src/gtr-message-table.c
index 98b87f8c..5479d0bc 100644
--- a/src/gtr-message-table.c
+++ b/src/gtr-message-table.c
@@ -104,9 +104,7 @@ gtr_message_table_selection_changed (GtkTreeSelection *selection,
       gtk_tree_model_get (model, &iter,
                           GTR_MESSAGE_TABLE_MODEL_POINTER_COLUMN, &msg, -1);
 
-      if (msg != NULL
-          && g_utf8_collate (gtr_msg_get_msgid (msg),
-                             gtr_msg_get_msgid (current_msg->data)))
+      if (msg != NULL)
         {
           g_signal_handlers_block_by_func (priv->tab, showed_message_cb, table);
           gtr_tab_message_go_to (priv->tab, msg,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]