[gnome-boxes/gnome-3-30] vm-configurator: Hardcode xmlns URI
- From: Felipe Borges <felipeborges src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-boxes/gnome-3-30] vm-configurator: Hardcode xmlns URI
- Date: Tue, 25 Sep 2018 08:05:27 +0000 (UTC)
commit 3ec818cbc1635d0b22e79654a2d2755c67638216
Author: Cole Robinson <crobinso redhat com>
Date: Wed Sep 5 15:41:01 2018 -0400
vm-configurator: Hardcode xmlns URI
Don't use PACKAGE_URL; if it changes in the future and this usage
site isn't change, boxes won't be able to read it's pre-existing
VM metadata. In fact it appears this already happened, see
912ff3ec520e
An xmlns URI doesn't need to actually be resolvable, just unique.
So let's hardcode the current value and never change it
src/vm-configurator.vala | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
---
diff --git a/src/vm-configurator.vala b/src/vm-configurator.vala
index 3090e138..dcff9d5e 100644
--- a/src/vm-configurator.vala
+++ b/src/vm-configurator.vala
@@ -9,7 +9,9 @@
private class Boxes.VMConfigurator {
private const string BOXES_NS = "boxes";
- private const string BOXES_NS_URI = Config.PACKAGE_URL;
+ /* This should not reference PACKAGE_URL, which could change in the
+ future, but this is effectively part of boxes XML API */
+ private const string BOXES_NS_URI = "https://wiki.gnome.org/Apps/Boxes";
private const string BOXES_OLD_NS_URI = "http://live.gnome.org/Boxes/";
private const string WEBDAV_CHANNEL_URI = "org.spice-space.webdav.0";
private const string BOXES_XML = "<gnome-boxes>%s</gnome-boxes>";
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]