[network-manager-applet: 4/4] libnma: merge branch 'th/revert-no-show-all'



commit f3b84748bb3377d503254a387da0f47fddbdcf9c
Merge: 9b63cc95 f56334c3
Author: Thomas Haller <thaller redhat com>
Date:   Fri Sep 21 09:54:09 2018 +0200

    libnma: merge branch 'th/revert-no-show-all'
    
    This broke gnome-control-center and nm-connection-editor,
    which call gtk_widget_show_all().
    
    Two offending gtk_widget_show_all() calls by nm-connection-editor
    were removed in response to the issue for nm-openvpn's certificate
    password ([1], [2], [3], [4]). Of course, older versions of nm-c-e
    and all versions of gnome-control-center are still broken by the change.
    
    However, there are other issues like missing 802-1x tabs [5].
    
    It's not acceptable to break existing users of libnma. Even if they
    possibly should be fixed.
    
    For the moment, revert the patches.
    
    [1] https://gitlab.gnome.org/GNOME/NetworkManager-openvpn/issues/6
    [2] https://gitlab.gnome.org/GNOME/NetworkManager-openvpn/issues/7
    [3] https://gitlab.gnome.org/GNOME/network-manager-applet/issues/20
    [4] https://bugzilla.redhat.com/show_bug.cgi?id=1626397
    [5] https://gitlab.gnome.org/GNOME/network-manager-applet/issues/25
    
    https://gitlab.gnome.org/GNOME/network-manager-applet/merge_requests/27
    
    Fixes: 07d900c0b3a52ee7aefc2f24e62914d40113b24b

 src/connection-editor/page-8021x-security.c |  1 +
 src/connection-editor/page-vpn.c            |  1 +
 src/libnma/nma-file-cert-chooser.c          |  7 +++++++
 src/libnma/nma-mobile-wizard.ui             |  2 +-
 src/libnma/nma-vpn-password-dialog.ui       | 18 +++++++++++-------
 5 files changed, 21 insertions(+), 8 deletions(-)
---


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]