[epiphany/gnome-3-30] Fix JSCValue leaks caught by -Wunused-result
- From: Michael Catanzaro <mcatanzaro src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [epiphany/gnome-3-30] Fix JSCValue leaks caught by -Wunused-result
- Date: Wed, 12 Sep 2018 11:55:26 +0000 (UTC)
commit cfc11b512002f949b7cff108e117e7625427f09b
Author: Michael Catanzaro <mcatanzaro igalia com>
Date: Sun Sep 2 15:27:02 2018 -0500
Fix JSCValue leaks caught by -Wunused-result
embed/web-extension/ephy-web-overview-model.c | 18 +++++++++++++-----
1 file changed, 13 insertions(+), 5 deletions(-)
---
diff --git a/embed/web-extension/ephy-web-overview-model.c b/embed/web-extension/ephy-web-overview-model.c
index 3acd92183..6ca2abe96 100644
--- a/embed/web-extension/ephy-web-overview-model.c
+++ b/embed/web-extension/ephy-web-overview-model.c
@@ -124,12 +124,14 @@ ephy_web_overview_model_notify_urls_changed (EphyWebOverviewModel *model)
g_hash_table_iter_init (&iter, model->urls_listeners);
while (g_hash_table_iter_next (&iter, &key, NULL)) {
JSCValue *value;
+ JSCValue *ret;
value = jsc_weak_value_get_value (JSC_WEAK_VALUE (key));
if (value && jsc_value_is_function (value)) {
if (!urls)
urls = ephy_web_overview_model_urls_to_js_value (model, jsc_value_get_context (value));
- jsc_value_function_call (value, G_TYPE_PTR_ARRAY, urls, G_TYPE_NONE);
+ ret = jsc_value_function_call (value, G_TYPE_PTR_ARRAY, urls, G_TYPE_NONE);
+ g_object_unref (ret);
}
if (value)
g_object_unref (value);
@@ -150,11 +152,14 @@ ephy_web_overview_model_notify_thumbnail_changed (EphyWebOverviewModel *model,
g_hash_table_iter_init (&iter, model->thumbnail_listeners);
while (g_hash_table_iter_next (&iter, &key, NULL)) {
JSCValue *value;
+ JSCValue *ret;
value = jsc_weak_value_get_value (JSC_WEAK_VALUE (key));
if (value) {
- if (jsc_value_is_function (value))
- jsc_value_function_call (value, G_TYPE_STRING, url, G_TYPE_STRING, path, G_TYPE_NONE);
+ if (jsc_value_is_function (value)) {
+ ret = jsc_value_function_call (value, G_TYPE_STRING, url, G_TYPE_STRING, path, G_TYPE_NONE);
+ g_object_unref (ret);
+ }
g_object_unref (value);
}
}
@@ -171,11 +176,14 @@ ephy_web_overview_model_notify_title_changed (EphyWebOverviewModel *model,
g_hash_table_iter_init (&iter, model->title_listeners);
while (g_hash_table_iter_next (&iter, &key, NULL)) {
JSCValue *value;
+ JSCValue *ret;
value = jsc_weak_value_get_value (JSC_WEAK_VALUE (key));
if (value) {
- if (jsc_value_is_function (value))
- jsc_value_function_call (value, G_TYPE_STRING, url, G_TYPE_STRING, title, G_TYPE_NONE);
+ if (jsc_value_is_function (value)) {
+ ret = jsc_value_function_call (value, G_TYPE_STRING, url, G_TYPE_STRING, title, G_TYPE_NONE);
+ g_object_unref (ret);
+ }
g_object_unref (value);
}
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]