[gnome-control-center/wip/oholy/libpwquality-crashes: 23/25] user-accounts: Do not set user for password dialog redundantly
- From: Robert Ancell <rancell src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-control-center/wip/oholy/libpwquality-crashes: 23/25] user-accounts: Do not set user for password dialog redundantly
- Date: Mon, 10 Sep 2018 22:04:38 +0000 (UTC)
commit 44c5c9e50b182246aed20f21fa18af4a2c061775
Author: Ondrej Holy <oholy redhat com>
Date: Thu Aug 30 16:07:36 2018 +0200
user-accounts: Do not set user for password dialog redundantly
um_password_dialog_set_user() is called from on_permission_changed()
respective show_user(), which more or less means on every change in
the panel. It it pretty enough to call this before opening the password
dialog, which is already done over change_password() callback. Let's
remove the redundant call which may lead to unwanted failures among
others.
https://gitlab.gnome.org/GNOME/gnome-control-center/issues/171
panels/user-accounts/um-user-panel.c | 2 --
1 file changed, 2 deletions(-)
---
diff --git a/panels/user-accounts/um-user-panel.c b/panels/user-accounts/um-user-panel.c
index eaa77bdb6..b9a675f81 100644
--- a/panels/user-accounts/um-user-panel.c
+++ b/panels/user-accounts/um-user-panel.c
@@ -1286,8 +1286,6 @@ on_permission_changed (GPermission *permission,
gtk_widget_set_sensitive (get_widget (self, "last-login-button"), FALSE);
add_unlock_tooltip (get_widget (self, "last-login-button"));
}
-
- um_password_dialog_set_user (self->password_dialog, user);
}
static void
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]