[libgda: 1/2] DDL: ..._free() methods was removed
- From: Daniel Espinosa Ortiz <despinosa src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [libgda: 1/2] DDL: ..._free() methods was removed
- Date: Thu, 6 Sep 2018 21:09:29 +0000 (UTC)
commit ded5f5134a91abd3798adbdd864a409d444424db
Author: Pavlo Solntsev <p sun fun gmail com>
Date: Thu Sep 6 12:47:36 2018 -0500
DDL: ..._free() methods was removed
libgda/gda-ddl-base.h | 2 --
libgda/gda-ddl-column.c | 13 -------------
libgda/gda-ddl-column.h | 1 -
libgda/gda-ddl-table.c | 4 ++--
tests/ddl/check-ddl-column.c | 2 +-
tests/ddl/check-ddl-fkey.c | 2 +-
6 files changed, 4 insertions(+), 20 deletions(-)
---
diff --git a/libgda/gda-ddl-base.h b/libgda/gda-ddl-base.h
index f4c6e1156..b3cc14a42 100644
--- a/libgda/gda-ddl-base.h
+++ b/libgda/gda-ddl-base.h
@@ -55,8 +55,6 @@ const gchar* gda_ddl_base_get_schema (GdaDdlBase *self);
void gda_ddl_base_set_schema (GdaDdlBase *self,
const gchar *schema);
-void gda_ddl_base_free (GdaDdlBase *self);
-
gint gda_ddl_base_compare (GdaDdlBase *a, GdaDdlBase *b);
#define GDA_BOOL_TO_STR(x) (x ? "TRUE" : "FALSE")
diff --git a/libgda/gda-ddl-column.c b/libgda/gda-ddl-column.c
index b8c1bc70b..ee1417850 100644
--- a/libgda/gda-ddl-column.c
+++ b/libgda/gda-ddl-column.c
@@ -304,19 +304,6 @@ gda_ddl_column_init (GdaDdlColumn *self)
priv->mp_comment = NULL;
}
-/**
- * gda_ddl_column_free:
- * @self: a #GdaDdlColumn instance
- *
- * Convenient function to free the object
- *
- * Since: 6.0
- */
-void gda_ddl_column_free (GdaDdlColumn *self)
-{
- g_clear_object (&self);
-}
-
/**
* gda_ddl_column_parse_node: (skip)
* @self: #GdaDdlColumn object to store parsed data
diff --git a/libgda/gda-ddl-column.h b/libgda/gda-ddl-column.h
index ff22947d9..3748ec105 100644
--- a/libgda/gda-ddl-column.h
+++ b/libgda/gda-ddl-column.h
@@ -54,7 +54,6 @@ GQuark gda_ddl_column_error_quark (void);
GdaDdlColumn* gda_ddl_column_new (void);
GdaDdlColumn* gda_ddl_column_new_from_meta (GdaMetaTableColumn *column);
-void gda_ddl_column_free (GdaDdlColumn *self);
const gchar* gda_ddl_column_get_name (GdaDdlColumn *self);
void gda_ddl_column_set_name (GdaDdlColumn *self, const gchar *name);
diff --git a/libgda/gda-ddl-table.c b/libgda/gda-ddl-table.c
index 31c05dfa2..c735489af 100644
--- a/libgda/gda-ddl-table.c
+++ b/libgda/gda-ddl-table.c
@@ -108,7 +108,7 @@ gda_ddl_table_finalize (GObject *object)
if (priv->mp_fkeys)
g_list_free_full (priv->mp_fkeys, (GDestroyNotify) g_object_unref);
if (priv->mp_columns)
- g_list_free_full (priv->mp_columns, (GDestroyNotify)gda_ddl_column_free);
+ g_list_free_full (priv->mp_columns, (GDestroyNotify)g_object_unref);
g_free (priv->mp_comment);
@@ -249,7 +249,7 @@ gda_ddl_table_parse_node (GdaDdlBuildable *buildable,
if (!gda_ddl_buildable_parse_node(GDA_DDL_BUILDABLE (column),
it, error))
{
- gda_ddl_column_free (column);
+ g_object_unref(column);
return FALSE;
}
else
diff --git a/tests/ddl/check-ddl-column.c b/tests/ddl/check-ddl-column.c
index 90f4026d9..fdda27f7a 100644
--- a/tests/ddl/check-ddl-column.c
+++ b/tests/ddl/check-ddl-column.c
@@ -250,7 +250,7 @@ test_ddl_column_cleanup (CheckDdlObject *self,
gconstpointer user_data)
{
g_free (self->xmlfile);
- gda_ddl_column_free (self->column);
+ g_object_unref (self->column);
xmlFreeDoc (self->doc);
}
diff --git a/tests/ddl/check-ddl-fkey.c b/tests/ddl/check-ddl-fkey.c
index 18bfee1ec..3372832b7 100644
--- a/tests/ddl/check-ddl-fkey.c
+++ b/tests/ddl/check-ddl-fkey.c
@@ -90,7 +90,7 @@ test_ddl_fkey_run1 (void)
g_print ("Run 1 start\n");
GdaDdlFkey *self = gda_ddl_fkey_new ();
- gda_ddl_fkey_free (self);
+ g_object_unref (self);
g_print ("Run 1 end\n");
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]