GNOME.org
 

[vala/0.36] gobject-2.0, gtk+-*.0: Fix some GLib.Value out/ref parameters

commit a6a40f6d53d284f0c86dd92602803373d2820ab2
Author: Rico Tzschichholz <ricotz ubuntu com>
Date:   Mon Aug 13 16:48:46 2018 +0200

    gobject-2.0,gtk+-*.0: Fix some GLib.Value out/ref parameters
    
    This is required due to GLib.Value being bound as struct.

 vapi/gobject-2.0.vapi                    |  4 ++--
 vapi/gtk+-2.0.vapi                       |  6 +++---
 vapi/gtk+-3.0.vapi                       | 16 ++++++++--------
 vapi/gtk+-4.0.vapi                       |  8 ++++----
 vapi/metadata/Gtk-4.0.metadata           |  7 +++++++
 vapi/packages/gtk+-2.0/gtk+-2.0.metadata |  6 +++++-
 vapi/packages/gtk+-3.0/gtk+-3.0.metadata | 14 ++++++++------
 7 files changed, 37 insertions(+), 24 deletions(-)
---
diff --git a/vapi/gobject-2.0.vapi b/vapi/gobject-2.0.vapi
index 197b81777..0bc3b1fba 100644
--- a/vapi/gobject-2.0.vapi
+++ b/vapi/gobject-2.0.vapi
@@ -259,12 +259,12 @@ namespace GLib {
                public void set_qdata (GLib.Quark quark, void* data);
                public void set_qdata_full (GLib.Quark quark, void* data, GLib.DestroyNotify destroy);
                [CCode (cname = "g_param_value_set_default")]
-               public void set_value_default (GLib.Value value);
+               public void set_value_default (ref GLib.Value value);
                public void sink ();
                public void* steal_qdata (GLib.Quark quark);
                public void unref ();
                [CCode (cname = "g_param_value_convert")]
-               public bool value_convert (GLib.Value src_value, GLib.Value dest_value, bool 
strict_validation);
+               public bool value_convert (GLib.Value src_value, ref GLib.Value dest_value, bool 
strict_validation);
                [CCode (cname = "g_param_value_defaults")]
                public bool value_defaults (GLib.Value value);
                [CCode (cname = "g_param_value_validate")]
diff --git a/vapi/gtk+-2.0.vapi b/vapi/gtk+-2.0.vapi
index 2ffd70bda..17d0d5cf8 100644
--- a/vapi/gtk+-2.0.vapi
+++ b/vapi/gtk+-2.0.vapi
@@ -1360,7 +1360,7 @@ namespace Gtk {
                protected Container ();
                public void add_with_properties (Gtk.Widget widget, ...);
                public void child_get (Gtk.Widget child, ...);
-               public void child_get_property (Gtk.Widget child, string property_name, GLib.Value value);
+               public void child_get_property (Gtk.Widget child, string property_name, ref GLib.Value value);
                public void child_get_valist (Gtk.Widget child, string first_property_name, va_list var_args);
                public void child_set (Gtk.Widget child, ...);
                public void child_set_property (Gtk.Widget child, string property_name, GLib.Value value);
@@ -1376,7 +1376,7 @@ namespace Gtk {
                public void @foreach (Gtk.Callback callback);
                public uint get_border_width ();
                [NoWrapper]
-               public virtual void get_child_property (Gtk.Widget child, uint property_id, GLib.Value value, 
GLib.ParamSpec pspec);
+               public virtual void get_child_property (Gtk.Widget child, uint property_id, ref GLib.Value 
value, GLib.ParamSpec pspec);
                public GLib.List<weak Gtk.Widget> get_children ();
                public bool get_focus_chain (out GLib.List<weak Gtk.Widget> focusable_widgets);
                public unowned Gtk.Widget get_focus_child ();
@@ -4245,7 +4245,7 @@ namespace Gtk {
                [NoWrapper]
                public virtual void draw_vline (Gdk.Window window, Gtk.StateType state_type, Gdk.Rectangle 
area, Gtk.Widget widget, string detail, int y1_, int y2_, int x);
                public void @get (GLib.Type widget_type, ...);
-               public void get_style_property (GLib.Type widget_type, string property_name, out GLib.Value 
value);
+               public void get_style_property (GLib.Type widget_type, string property_name, ref GLib.Value 
value);
                public void get_valist (GLib.Type widget_type, string first_property_name, void* var_args);
                [NoWrapper]
                public virtual void init_from_rc (Gtk.RcStyle rc_style);
diff --git a/vapi/gtk+-3.0.vapi b/vapi/gtk+-3.0.vapi
index c1793fa19..b304f4614 100644
--- a/vapi/gtk+-3.0.vapi
+++ b/vapi/gtk+-3.0.vapi
@@ -950,7 +950,7 @@ namespace Gtk {
                public void attribute_disconnect (Gtk.CellRenderer renderer, string attribute);
                public int attribute_get_column (Gtk.CellRenderer renderer, string attribute);
                public void cell_get (Gtk.CellRenderer renderer, ...);
-               public void cell_get_property (Gtk.CellRenderer renderer, string property_name, GLib.Value 
value);
+               public void cell_get_property (Gtk.CellRenderer renderer, string property_name, ref 
GLib.Value value);
                public void cell_get_valist (Gtk.CellRenderer renderer, string first_property_name, va_list 
var_args);
                public void cell_set (Gtk.CellRenderer renderer, ...);
                public void cell_set_property (Gtk.CellRenderer renderer, string property_name, GLib.Value 
value);
@@ -966,7 +966,7 @@ namespace Gtk {
                public Gdk.Rectangle get_cell_allocation (Gtk.CellAreaContext context, Gtk.Widget widget, 
Gtk.CellRenderer renderer, Gdk.Rectangle cell_area);
                public unowned Gtk.CellRenderer get_cell_at_position (Gtk.CellAreaContext context, Gtk.Widget 
widget, Gdk.Rectangle cell_area, int x, int y, out Gdk.Rectangle alloc_area);
                [NoWrapper]
-               public virtual void get_cell_property (Gtk.CellRenderer renderer, uint property_id, 
GLib.Value value, GLib.ParamSpec pspec);
+               public virtual void get_cell_property (Gtk.CellRenderer renderer, uint property_id, ref 
GLib.Value value, GLib.ParamSpec pspec);
                public unowned string get_current_path_string ();
                public unowned Gtk.CellEditable get_edit_widget ();
                public unowned Gtk.CellRenderer get_edited_cell ();
@@ -1622,7 +1622,7 @@ namespace Gtk {
                protected Container ();
                public void add_with_properties (Gtk.Widget widget, ...);
                public void child_get (Gtk.Widget child, ...);
-               public void child_get_property (Gtk.Widget child, string property_name, GLib.Value value);
+               public void child_get_property (Gtk.Widget child, string property_name, ref GLib.Value value);
                public void child_get_valist (Gtk.Widget child, string first_property_name, va_list var_args);
                public void child_notify (Gtk.Widget child, string child_property);
                public void child_notify_by_pspec (Gtk.Widget child, GLib.ParamSpec pspec);
@@ -1641,7 +1641,7 @@ namespace Gtk {
                public void @foreach (Gtk.Callback callback);
                public uint get_border_width ();
                [NoWrapper]
-               public virtual void get_child_property (Gtk.Widget child, uint property_id, GLib.Value value, 
GLib.ParamSpec pspec);
+               public virtual void get_child_property (Gtk.Widget child, uint property_id, ref GLib.Value 
value, GLib.ParamSpec pspec);
                public GLib.List<weak Gtk.Widget> get_children ();
                public bool get_focus_chain (out GLib.List<weak Gtk.Widget> focusable_widgets);
                public unowned Gtk.Widget? get_focus_child ();
@@ -5268,7 +5268,7 @@ namespace Gtk {
                [NoWrapper]
                public virtual void draw_vline (Cairo.Context cr, Gtk.StateType state_type, Gtk.Widget 
widget, string detail, int y1_, int y2_, int x);
                public void @get (GLib.Type widget_type, ...);
-               public void get_style_property (GLib.Type widget_type, string property_name, out GLib.Value 
value);
+               public void get_style_property (GLib.Type widget_type, string property_name, ref GLib.Value 
value);
                public void get_valist (GLib.Type widget_type, string first_property_name, void* var_args);
                public bool has_context ();
                [NoWrapper]
@@ -5304,7 +5304,7 @@ namespace Gtk {
                public Gtk.Border get_padding (Gtk.StateFlags state);
                public unowned Gtk.StyleContext? get_parent ();
                public unowned Gtk.WidgetPath get_path ();
-               public GLib.Value get_property (string property, Gtk.StateFlags state);
+               public void get_property (string property, Gtk.StateFlags state, ref GLib.Value value);
                public int get_scale ();
                public unowned Gdk.Screen get_screen ();
                public unowned Gtk.CssSection get_section (string property);
@@ -5978,7 +5978,7 @@ namespace Gtk {
                public unowned Gdk.Screen get_screen ();
                public Gtk.StateFlags get_state ();
                public void get_style (...);
-               public GLib.Value get_style_property (string property_name);
+               public void get_style_property (string property_name, ref GLib.Value value);
                public void get_style_valist (va_list args);
                public void get_valist (Gtk.StateFlags state, va_list args);
                public bool has_class (string style_class);
@@ -7672,7 +7672,7 @@ namespace Gtk {
        public interface StyleProvider : GLib.Object {
                public abstract unowned Gtk.IconFactory get_icon_factory (Gtk.WidgetPath path);
                public abstract Gtk.StyleProperties get_style (Gtk.WidgetPath path);
-               public abstract bool get_style_property (Gtk.WidgetPath path, Gtk.StateFlags state, 
GLib.ParamSpec pspec, out GLib.Value value);
+               public abstract bool get_style_property (Gtk.WidgetPath path, Gtk.StateFlags state, 
GLib.ParamSpec pspec, ref GLib.Value value);
        }
        [CCode (cheader_filename = "gtk/gtk.h")]
        public interface ToolShell : Gtk.Widget {
diff --git a/vapi/gtk+-4.0.vapi b/vapi/gtk+-4.0.vapi
index 4219a25cd..a8ddc914a 100644
--- a/vapi/gtk+-4.0.vapi
+++ b/vapi/gtk+-4.0.vapi
@@ -7681,7 +7681,7 @@ namespace Gtk {
                [Version (since = "3.0")]
                public void cell_get (Gtk.CellRenderer renderer, ...);
                [Version (since = "3.0")]
-               public void cell_get_property (Gtk.CellRenderer renderer, string property_name, GLib.Value 
value);
+               public void cell_get_property (Gtk.CellRenderer renderer, string property_name, ref 
GLib.Value value);
                [Version (since = "3.0")]
                public void cell_get_valist (Gtk.CellRenderer renderer, string first_property_name, [CCode 
(type = "va_list")] va_list var_args);
                [Version (since = "3.0")]
@@ -7710,7 +7710,7 @@ namespace Gtk {
                [Version (since = "3.0")]
                public unowned Gtk.CellRenderer get_cell_at_position (Gtk.CellAreaContext context, Gtk.Widget 
widget, Gdk.Rectangle cell_area, int x, int y, out Gdk.Rectangle alloc_area);
                [NoWrapper]
-               public virtual void get_cell_property (Gtk.CellRenderer renderer, uint property_id, 
GLib.Value value, GLib.ParamSpec pspec);
+               public virtual void get_cell_property (Gtk.CellRenderer renderer, uint property_id, ref 
GLib.Value value, GLib.ParamSpec pspec);
                [Version (since = "3.0")]
                public unowned string get_current_path_string ();
                [Version (since = "3.0")]
@@ -8505,7 +8505,7 @@ namespace Gtk {
                protected Container ();
                public void add_with_properties (Gtk.Widget widget, ...);
                public void child_get (Gtk.Widget child, ...);
-               public void child_get_property (Gtk.Widget child, string property_name, GLib.Value value);
+               public void child_get_property (Gtk.Widget child, string property_name, ref GLib.Value value);
                public void child_get_valist (Gtk.Widget child, string first_property_name, [CCode (type = 
"va_list")] va_list var_args);
                [Version (since = "3.2")]
                public void child_notify (Gtk.Widget child, string child_property);
@@ -8520,7 +8520,7 @@ namespace Gtk {
                public virtual void forall (Gtk.Callback callback);
                public void @foreach (Gtk.Callback callback);
                [NoWrapper]
-               public virtual void get_child_property (Gtk.Widget child, uint property_id, GLib.Value value, 
GLib.ParamSpec pspec);
+               public virtual void get_child_property (Gtk.Widget child, uint property_id, ref GLib.Value 
value, GLib.ParamSpec pspec);
                public GLib.List<weak Gtk.Widget> get_children ();
                public bool get_focus_chain (out GLib.List<weak Gtk.Widget> focusable_widgets);
                public unowned Gtk.Adjustment? get_focus_hadjustment ();
diff --git a/vapi/metadata/Gtk-4.0.metadata b/vapi/metadata/Gtk-4.0.metadata
index 46353448c..e768b9a91 100644
--- a/vapi/metadata/Gtk-4.0.metadata
+++ b/vapi/metadata/Gtk-4.0.metadata
@@ -294,6 +294,13 @@ TargetPair skip
 // Vala-specific, not really bugs
 /////////////////////////////////
 
+CellArea
+  .cell_get_property.value ref
+  .get_cell_property.value ref
+Container
+  .get_child_property.value ref
+  .child_get_property.value ref
+
 // Backwards compatibility
 AccelGroup
   .find type="Gtk.AccelKey*"
diff --git a/vapi/packages/gtk+-2.0/gtk+-2.0.metadata b/vapi/packages/gtk+-2.0/gtk+-2.0.metadata
index b413f7829..a4bcf9de5 100644
--- a/vapi/packages/gtk+-2.0/gtk+-2.0.metadata
+++ b/vapi/packages/gtk+-2.0/gtk+-2.0.metadata
@@ -117,6 +117,8 @@ gtk_calendar_set_detail_func.destroy hidden="1"
 GtkCalendarDetailFunc transfer_ownership="1"
 GtkCallbackMarshal hidden="1"
 GtkCell.u hidden="1"
+gtk_cell_area_cell_get_property.value is_ref="1"
+gtk_cell_area_get_cell_property.value is_ref="1"
 GtkCellEditable::editing_done has_emitter="1"
 GtkCellEditable::remove_widget has_emitter="1"
 gtk_cell_editable_start_editing.event nullable="1"
@@ -194,12 +196,14 @@ GtkContainer::composite_name transfer_ownership="1"
 GtkContainer::remove has_emitter="1"
 GtkContainer::set_focus_child has_emitter="1"
 GtkContainer::set_focus_child.widget nullable="1"
+gtk_container_child_get_property.value is_ref="1"
 gtk_container_child_get_valist.var_args type_name="va_list"
 gtk_container_child_set_valist.var_args type_name="va_list"
 gtk_container_forall virtual="0"
 gtk_container_forall.callback_data hidden="1"
 gtk_container_foreach.callback_data hidden="1"
 gtk_container_get_children transfer_ownership="1" type_arguments="unowned Widget"
+gtk_container_get_child_property.value is_ref="1"
 gtk_container_get_focus_chain.focusable_widgets is_out="1" takes_ownership="1" type_arguments="unowned 
Widget"
 gtk_container_set_focus_chain.focusable_widgets type_arguments="Widget"
 GtkContainerClass name="pointer"
@@ -725,7 +729,7 @@ GtkStyle.bg_pixmap weak="0"
 gtk_style_clone transfer_ownership="1"
 gtk_style_copy virtual="0" type_name="Style" transfer_ownership="1"
 gtk_style_lookup_color.color is_out="1"
-gtk_style_get_style_property.value is_out="1"
+gtk_style_get_style_property.value is_ref="1"
 gtk_table_get_size.rows is_out="1"
 gtk_table_get_size.columns is_out="1"
 GtkTable.children type_arguments="TableChild"
diff --git a/vapi/packages/gtk+-3.0/gtk+-3.0.metadata b/vapi/packages/gtk+-3.0/gtk+-3.0.metadata
index 0630dac91..598f1cb98 100644
--- a/vapi/packages/gtk+-3.0/gtk+-3.0.metadata
+++ b/vapi/packages/gtk+-3.0/gtk+-3.0.metadata
@@ -229,6 +229,8 @@ gtk_cell_area_context_get_preferred_width.minimum_width is_out="1"
 gtk_cell_area_context_get_preferred_width.natural_width is_out="1"
 gtk_cell_area_context_get_preferred_width_for_height.minimum_width is_out="1"
 gtk_cell_area_context_get_preferred_width_for_height.natural_width is_out="1"
+gtk_cell_area_cell_get_property.value is_ref="1"
+gtk_cell_area_get_cell_property.value is_ref="1"
 GtkCellEditable::editing_done has_emitter="1"
 GtkCellEditable::remove_widget has_emitter="1"
 gtk_cell_editable_start_editing.event nullable="1"
@@ -348,6 +350,7 @@ GtkContainer::composite_name transfer_ownership="1"
 GtkContainer::remove has_emitter="1"
 GtkContainer::set_focus_child has_emitter="1"
 GtkContainer::set_focus_child.child nullable="1"
+gtk_container_child_get_property.value is_ref="1"
 gtk_container_child_get_valist.var_args type_name="va_list"
 gtk_container_child_set_valist.var_args type_name="va_list"
 gtk_container_composite_name transfer_ownership="1"
@@ -360,6 +363,7 @@ gtk_container_get_focus_child nullable="1"
 gtk_container_get_focus_hadjustment nullable="1"
 gtk_container_get_focus_vadjustment nullable="1"
 gtk_container_get_path_for_child transfer_ownership="1"
+gtk_container_get_child_property.value is_ref="1"
 gtk_container_set_focus_chain.focusable_widgets type_arguments="Widget" deprecated_since="3.24"
 gtk_container_cell_accessible_get_children type_arguments="CellAccessible"
 gtk_container_class_find_child_property hidden="1"
@@ -1284,8 +1288,7 @@ gtk_style_context_get_margin.margin hidden="1"
 gtk_style_context_get_padding type_name="Gtk.Border"
 gtk_style_context_get_padding.padding hidden="1"
 gtk_style_context_get_parent nullable="1"
-gtk_style_context_get_property type_name="GLib.Value"
-gtk_style_context_get_property.value hidden="1"
+gtk_style_context_get_property.value is_ref="1"
 gtk_style_context_get_style ellipsis="1"
 gtk_style_context_get_style_valist.args type_name="va_list"
 gtk_style_context_get_valist.args type_name="va_list"
@@ -1297,7 +1300,7 @@ gtk_style_context_set_parent.parent nullable="1"
 gtk_style_context_state_is_running.progress is_out="1"
 gtk_style_context_to_string transfer_ownership="1"
 gtk_style_lookup_color.color is_out="1"
-gtk_style_get_style_property.value is_out="1"
+gtk_style_get_style_property.value is_ref="1"
 gtk_style_properties_register_property.parse_func nullable="1"
 gtk_style_properties_get ellipsis="1"
 gtk_style_properties_get_property.value is_out="1"
@@ -1310,7 +1313,7 @@ gtk_style_render_icon.widget nullable="1"
 gtk_style_render_icon.detail nullable="1"
 gtk_style_render_icon_pixbuf transfer_ownership="1"
 gtk_style_provider_get_style transfer_ownership="1"
-gtk_style_provider_get_style_property.value is_out="1"
+gtk_style_provider_get_style_property.value is_ref="1"
 GtkStyleProviderPrivate hidden="1"
 gtk_symbolic_color_resolve.props nullable="1"
 gtk_symbolic_color_resolve.resolved_color is_out="1"
@@ -1482,8 +1485,7 @@ gtk_theming_engine_get_property.value hidden="1"
 gtk_theming_engine_register_property.parse_func nullable="1"
 gtk_theming_engine_state_is_running deprecated_since="3.6"
 gtk_theming_engine_get_style ellipsis="1"
-gtk_theming_engine_get_style_property type_name="GLib.Value"
-gtk_theming_engine_get_style_property.value hidden="1"
+gtk_theming_engine_get_style_property.value is_ref="1"
 gtk_theming_engine_get_style_valist.args type_name="va_list"
 gtk_theming_engine_get_valist.args type_name="va_list"
 gtk_theming_engine_lookup_color.color is_out="1"
[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]