[NetworkManager-vpnc/lr/no-gtk-display] auth-dialog: don't connect to Gtk+ display until necessary

[Lubomir Rintel <lkundrak src gnome org>]

commit d80f3977913652ce44700b41cc702a2ad1f1cc63
Author: Lubomir Rintel <lkundrak v3 sk>
Date:   Fri Oct 19 17:30:01 2018 +0200

    auth-dialog: don't connect to Gtk+ display until necessary
    
    In the external UI mode we may end up not needing a connection to the
    display server at all.
    
    This splits the parsing of Gtk+ command line arguments from connection
    to the display. This also fixes the --help output to actually include
    the Gtk+ arguments (such as --display).

 NEWS               | 9 +++++++++
 auth-dialog/main.c | 7 ++++---
 2 files changed, 13 insertions(+), 3 deletions(-)
---
diff --git a/NEWS b/NEWS
index b5afcc4..d6877ca 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,12 @@
+=======================================================
+NetworkManager-vpnc-1.2.8 (not released yet)
+Overview of changes since NetworkManager-vpnc-1.2.6
+=======================================================
+
+* The auth helper in external UI mode can now be run without a display
+  server. Future nmcli version will utilize this for handling the
+  secrets without a graphical desktop.
+
 =======================================================
 NetworkManager-vpnc-1.2.6
 Overview of changes since NetworkManager-vpnc-1.2.4
diff --git a/auth-dialog/main.c b/auth-dialog/main.c
index 9e73d1b..51d3213 100644
--- a/auth-dialog/main.c
+++ b/auth-dialog/main.c
@@ -17,7 +17,7 @@
  * with this program; if not, write to the Free Software Foundation, Inc.,
  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  *
- * (C) Copyright 2004 - 2011 Red Hat, Inc.
+ * (C) Copyright 2004 - 2018 Red Hat, Inc.
  */
 
 #include "nm-default.h"
@@ -221,6 +221,8 @@ std_ask_user (const char *vpn_name,
        g_return_val_if_fail (out_new_password != NULL, FALSE);
        g_return_val_if_fail (out_new_group_password != NULL, FALSE);
 
+       gtk_init (NULL, NULL);
+
        dialog = NMA_VPN_PASSWORD_DIALOG (nma_vpn_password_dialog_new (_("Authenticate VPN"), prompt, NULL));
 
        /* pre-fill dialog with existing passwords */
@@ -447,10 +449,9 @@ main (int argc, char *argv[])
        bind_textdomain_codeset (GETTEXT_PACKAGE, "UTF-8");
        textdomain (GETTEXT_PACKAGE);
 
-       gtk_init (&argc, &argv);
-
        context = g_option_context_new ("- vpnc auth dialog");
        g_option_context_add_main_entries (context, entries, GETTEXT_PACKAGE);
+       g_option_context_add_group (context, gtk_get_option_group (FALSE));
        if (!g_option_context_parse (context, &argc, &argv, &error)) {
                fprintf (stderr, "Error parsing options: %s\n", error->message);
                g_error_free (error);