[gnome-software/gnome-3-30] lib: Allow opening CAB files that resolve more than one GsApp (Fixes: #474)



commit 8e8887f890489959daa3400f531e7febf9e9f8b6
Author: Mario Limonciello <mario limonciello dell com>
Date:   Tue Oct 16 11:21:47 2018 -0500

    lib: Allow opening CAB files that resolve more than one GsApp (Fixes: #474)
    
    This allows installation of composite firmwares.  By default the first application
    will be displayed in gnome-software.
    
    The fwupd daemon will handle installation of the composite firmware when multiple
    devices in the same topology match the composite firmware.
    
    This was verified using a Dell USB-C dock and fwupd 1.1.3.

 lib/gs-plugin-loader.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
---
diff --git a/lib/gs-plugin-loader.c b/lib/gs-plugin-loader.c
index 55afa8bb..630d0c6c 100644
--- a/lib/gs-plugin-loader.c
+++ b/lib/gs-plugin-loader.c
@@ -3385,12 +3385,7 @@ gs_plugin_loader_process_thread_cb (GTask *task,
                }
                if (gs_app_list_length (list) > 1) {
                        g_autofree gchar *str = gs_plugin_job_to_string (helper->plugin_job);
-                       g_task_return_new_error (task,
-                                                GS_PLUGIN_ERROR,
-                                                GS_PLUGIN_ERROR_NOT_SUPPORTED,
-                                                "more than one application was created for %s",
-                                                str);
-                       return;
+                       g_debug ("more than one application was created for %s", str);
                }
        }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]