[nautilus/gnome-3-30] batch-rename-dialog: Fix use after free



commit 2d0f32669ad8916317a94566019069e77c39d885
Author: Ernestas Kulik <ernestask gnome org>
Date:   Tue Oct 16 15:43:25 2018 +0000

    batch-rename-dialog: Fix use after free
    
    destroy_conflicts_task_data() frees the task data struct before clearing
    the mutex and conditional variable inside it.
    
    Addresses https://gitlab.gnome.org/GNOME/nautilus/issues/628
    
    
    (cherry picked from commit ad55aba56383c48c126c94e710e7d6c04dbb3001)

 src/nautilus-batch-rename-dialog.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/src/nautilus-batch-rename-dialog.c b/src/nautilus-batch-rename-dialog.c
index e35f40ef1..d5722e06c 100644
--- a/src/nautilus-batch-rename-dialog.c
+++ b/src/nautilus-batch-rename-dialog.c
@@ -1320,10 +1320,10 @@ destroy_conflicts_task_data (gpointer data)
         g_list_free (task_data->directories);
     }
 
-    g_free (task_data);
-
     g_mutex_clear (&task_data->wait_ready_mutex);
     g_cond_clear (&task_data->wait_ready_condition);
+
+    g_free (task_data);
 }
 
 static void


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]