[NetworkManager-openconnect] Don't autosubmit if save_passwords is clear
- From: David Woodhouse <dwmw2 src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [NetworkManager-openconnect] Don't autosubmit if save_passwords is clear
- Date: Tue, 16 Oct 2018 16:55:46 +0000 (UTC)
commit fb5e8ef2e8193491cdc859860145f9008fb25e1d
Author: David Woodhouse <dwmw2 infradead org>
Date: Tue Oct 16 09:52:53 2018 -0700
Don't autosubmit if save_passwords is clear
The UI clears passwords if you unset the checkbox, but actually
does still attempt to populate from the secrets service. Which
means that if you clear 'save_passwords' manually through nmcli
or editing the config file, passwords can still be stored and
autosubmission can still happen... until now.
auth-dialog/main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
---
diff --git a/auth-dialog/main.c b/auth-dialog/main.c
index c69f729..585d072 100644
--- a/auth-dialog/main.c
+++ b/auth-dialog/main.c
@@ -1636,7 +1636,8 @@ static auth_ui_data *init_ui_data (char *vpn_name, GHashTable *options, GHashTab
g_free, g_free);
ui_data->success_passwords = g_hash_table_new_full (g_str_hash, g_str_equal,
g_free, keyring_password_free);
- ui_data->autosubmit = AUTOSUBMIT_LIMIT;
+ if (get_save_passwords (secrets))
+ ui_data->autosubmit = AUTOSUBMIT_LIMIT;
if (pipe(ui_data->cancel_pipes)) {
/* This should never happen, and the world is probably about
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]