[gnome-software] Remove the app menu kudo

[Kalev Lember <klember src gnome org>]

commit dda5d4277c9d3a086ea871cc307fef7d9170916c
Author: Kalev Lember <klember redhat com>
Date:   Thu Oct 11 14:07:25 2018 +0200

    Remove the app menu kudo
    
    gnome-shell no longer uses app menus in 3.32.

 lib/gs-app.c                | 4 ----
 lib/gs-app.h                | 2 --
 plugins/core/gs-appstream.c | 3 ---
 src/gs-details-page.c       | 1 -
 4 files changed, 10 deletions(-)
---
diff --git a/lib/gs-app.c b/lib/gs-app.c
index b3faa35c..a3b0454d 100644
--- a/lib/gs-app.c
+++ b/lib/gs-app.c
@@ -365,8 +365,6 @@ gs_app_kudos_to_string (guint64 kudos)
                g_ptr_array_add (array, "installs-user-docs");
        if ((kudos & GS_APP_KUDO_USES_NOTIFICATIONS) > 0)
                g_ptr_array_add (array, "uses-notifications");
-       if ((kudos & GS_APP_KUDO_USES_APP_MENU) > 0)
-               g_ptr_array_add (array, "uses-app-menu");
        if ((kudos & GS_APP_KUDO_HAS_KEYWORDS) > 0)
                g_ptr_array_add (array, "has-keywords");
        if ((kudos & GS_APP_KUDO_HAS_SCREENSHOTS) > 0)
@@ -3768,8 +3766,6 @@ gs_app_get_kudos_percentage (GsApp *app)
                percentage += 20;
        if ((priv->kudos & GS_APP_KUDO_HAS_KEYWORDS) > 0)
                percentage += 5;
-       if ((priv->kudos & GS_APP_KUDO_USES_APP_MENU) > 0)
-               percentage += 10;
        if ((priv->kudos & GS_APP_KUDO_HAS_SCREENSHOTS) > 0)
                percentage += 20;
        if ((priv->kudos & GS_APP_KUDO_HIGH_CONTRAST) > 0)
diff --git a/lib/gs-app.h b/lib/gs-app.h
index d4dd23d2..0b38c101 100644
--- a/lib/gs-app.h
+++ b/lib/gs-app.h
@@ -54,7 +54,6 @@ struct _GsAppClass
  * @GS_APP_KUDO_INSTALLS_USER_DOCS:    Installs user docs
  * @GS_APP_KUDO_USES_NOTIFICATIONS:    Registers notifications
  * @GS_APP_KUDO_HAS_KEYWORDS:          Has at least 1 keyword
- * @GS_APP_KUDO_USES_APP_MENU:         Uses an AppMenu for navigation
  * @GS_APP_KUDO_HAS_SCREENSHOTS:       Supplies screenshots
  * @GS_APP_KUDO_POPULAR:               Is popular
  * @GS_APP_KUDO_HIGH_CONTRAST:         Installs a high contrast icon
@@ -73,7 +72,6 @@ typedef enum {
        GS_APP_KUDO_INSTALLS_USER_DOCS          = 1 << 5,
        GS_APP_KUDO_USES_NOTIFICATIONS          = 1 << 6,
        GS_APP_KUDO_HAS_KEYWORDS                = 1 << 7,
-       GS_APP_KUDO_USES_APP_MENU               = 1 << 8,
        GS_APP_KUDO_HAS_SCREENSHOTS             = 1 << 9,
        GS_APP_KUDO_POPULAR                     = 1 << 10,
        GS_APP_KUDO_HIGH_CONTRAST               = 1 << 13,
diff --git a/plugins/core/gs-appstream.c b/plugins/core/gs-appstream.c
index 030fad77..4df4d6e7 100644
--- a/plugins/core/gs-appstream.c
+++ b/plugins/core/gs-appstream.c
@@ -697,9 +697,6 @@ gs_appstream_refine_app (GsPlugin *plugin,
                case AS_KUDO_KIND_USER_DOCS:
                        gs_app_add_kudo (app, GS_APP_KUDO_INSTALLS_USER_DOCS);
                        break;
-               case AS_KUDO_KIND_APP_MENU:
-                       gs_app_add_kudo (app, GS_APP_KUDO_USES_APP_MENU);
-                       break;
                case AS_KUDO_KIND_MODERN_TOOLKIT:
                        gs_app_add_kudo (app, GS_APP_KUDO_MODERN_TOOLKIT);
                        break;
diff --git a/src/gs-details-page.c b/src/gs-details-page.c
index d44561e6..7917f358 100644
--- a/src/gs-details-page.c
+++ b/src/gs-details-page.c
@@ -1137,7 +1137,6 @@ gs_details_page_refresh_all (GsDetailsPage *self)
        /* any of the various integration kudos */
        user_integration_bf = GS_APP_KUDO_SEARCH_PROVIDER |
                              GS_APP_KUDO_USES_NOTIFICATIONS |
-                             GS_APP_KUDO_USES_APP_MENU |
                              GS_APP_KUDO_HIGH_CONTRAST;
        ret = (kudos & user_integration_bf) > 0;
        gtk_widget_set_sensitive (self->image_details_kudo_integration, ret);