[gdm/wip/kill-x-on-login-too-plz: 4/4] local-display-factory: kill X on login just like wayland
- From: Ray Strode <halfline src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gdm/wip/kill-x-on-login-too-plz: 4/4] local-display-factory: kill X on login just like wayland
- Date: Thu, 11 Oct 2018 11:21:29 +0000 (UTC)
commit d40716e7b32c1cbfe48a19e1b12a4f7d200f9cfe
Author: Ray Strode <rstrode redhat com>
Date: Thu Oct 11 07:15:56 2018 -0400
local-display-factory: kill X on login just like wayland
These days we kill the wayland login screen during login to
conserve system resources.
We've been reluctant to do the same for X based login screens,
because X doesn't handle being killed in the background so well.
The main problem, VT switching out from under us, should no longer
be an issue since the commit before this one however.
There's still, I think, potentially problems with more obscure drivers.
On the other hand, we're seeing problems with keeping X running
with the very non-obscure nvidia driver, so maybe on balance, we should
just make the change and see how bad the fallout is.
daemon/gdm-local-display-factory.c | 9 ---------
1 file changed, 9 deletions(-)
---
diff --git a/daemon/gdm-local-display-factory.c b/daemon/gdm-local-display-factory.c
index 5430085e..c5b00a7f 100644
--- a/daemon/gdm-local-display-factory.c
+++ b/daemon/gdm-local-display-factory.c
@@ -730,7 +730,6 @@ static void
maybe_stop_greeter_in_background (GdmLocalDisplayFactory *factory,
GdmDisplay *display)
{
- g_autofree char *display_session_type = NULL;
gboolean doing_initial_setup = FALSE;
if (gdm_display_get_status (display) != GDM_DISPLAY_MANAGED) {
@@ -739,7 +738,6 @@ maybe_stop_greeter_in_background (GdmLocalDisplayFactory *factory,
}
g_object_get (G_OBJECT (display),
- "session-type", &display_session_type,
"doing-initial-setup", &doing_initial_setup,
NULL);
@@ -749,13 +747,6 @@ maybe_stop_greeter_in_background (GdmLocalDisplayFactory *factory,
return;
}
- /* we can only stop greeter for wayland sessions, since
- * X server would jump back on exit */
- if (g_strcmp0 (display_session_type, "wayland") != 0) {
- g_debug ("GdmLocalDisplayFactory: login window is running on Xorg, so ignoring");
- return;
- }
-
g_debug ("GdmLocalDisplayFactory: killing login window once its unused");
g_object_set (G_OBJECT (display), "status", GDM_DISPLAY_WAITING_TO_FINISH, NULL);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]