[gnome-software/ramcq/loading: 4/8] Do not assign mode when window is closed



commit 1e3052fec9bfb4673ef3d1eae93f33855785265f
Author: Robert McQueen <rob endlessm com>
Date:   Wed Oct 10 15:39:26 2018 +0100

    Do not assign mode when window is closed
    
    This could overwrite the loading state which the shell uses to prevent
    various actions which should be deferred until the initial refresh has
    finished.
    
    The GsApplication code that presents the application sets the mode to
    overview before showing the window, provided the loading is completed.

 src/gs-shell.c | 3 ---
 1 file changed, 3 deletions(-)
---
diff --git a/src/gs-shell.c b/src/gs-shell.c
index 1f5a0c9d..b760338b 100644
--- a/src/gs-shell.c
+++ b/src/gs-shell.c
@@ -779,9 +779,6 @@ main_window_closed_cb (GtkWidget *dialog, GdkEvent *event, gpointer user_data)
        g_application_withdraw_notification (g_application_get_default (),
                                             "install-resources");
 
-       /* When the window is closed, reset the initial mode to overview */
-       priv->mode = GS_SHELL_MODE_OVERVIEW;
-
        gs_shell_clean_back_entry_stack (shell);
        gtk_widget_hide (dialog);
        return TRUE;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]